Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRUD generator update.php contains {nameAttribute} in title #328

Closed
ricpelo opened this issue Jan 16, 2018 · 1 comment · Fixed by #329
Closed

CRUD generator update.php contains {nameAttribute} in title #328

ricpelo opened this issue Jan 16, 2018 · 1 comment · Fixed by #329
Labels
status:ready for adoption Feel free to implement this issue. type:bug Bug
Milestone
2.0.7

Comments

@ricpelo
Copy link
Contributor

ricpelo commented Jan 16, 2018

What steps will reproduce the problem?

  1. composer create-project --prefer-dist yiisoft/yii2-app-basic project
  2. Using Gii, generate a Socios model from socios table (columns: id, numero, nombre, direccion, telefono, borrado).
  3. Using Gii, generate a CRUD using the following parameters:
  • Model Class: app\models\Socios
  • Search Model Class: app\models\SociosSearch
  • Controller Class: app\controllers\SociosController
  • Everything else: default values.

What's expected?

views/socios/update.php view must contain the line:

$this->title = 'Update Socios: ' . $model->id;

What do you get instead?

views/socios/update.php incorrectly contains the line:

$this->title = 'Update Socios: {nameAttribute}'

Additional info

Q A
Yii version 2.0.13.1
PHP version 7.1.13-1+ubuntu16.04.1+deb.sury.org+1
Operating system Ubuntu 16.04.3 LTS
yii2-gii version 2.0.6
@samdark samdark added type:bug Bug status:ready for adoption Feel free to implement this issue. labels Jan 16, 2018
@samdark samdark added this to the 2.0.7 milestone Jan 16, 2018
@ricpelo ricpelo mentioned this issue Jan 16, 2018
Merged
samdark pushed a commit that referenced this issue Jan 16, 2018
@ricpelo @samdark
Fixes #328: Fix bug in CRUD update view generator
51e58d7
This was referenced Nov 22, 2018
Merged
Merged
@ricpelo
Copy link
Contributor Author

ricpelo commented Nov 22, 2018

Must be re-opened due to PR #383, fixed by PR #387 .

@ricpelo ricpelo mentioned this issue Nov 22, 2018
Closed
samdark pushed a commit that referenced this issue Nov 23, 2018
@ricpelo @samdark
Fix PR #383, fixing #328 again (#387)
89c3865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready for adoption Feel free to implement this issue. type:bug Bug
Projects
None yet
Milestone
2.0.7
Development

Successfully merging a pull request may close this issue.

Fix bug in CRUD update view generator
2 participants
@samdark @ricpelo