Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove component NodeRef #2783

Merged
merged 8 commits into from Jul 20, 2022
Merged

Remove component NodeRef #2783

merged 8 commits into from Jul 20, 2022

Commits on Jul 19, 2022

  1. don't attach noderef to components, add test case

    @hamza1311
    hamza1311 committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    c9f03c9 View commit details
    Browse the repository at this point in the history

  2. remove node_ref from VNode and VComp

    @hamza1311
    hamza1311 committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    8fdfb9f View commit details
    Browse the repository at this point in the history

  3. fmt & macro tests

    @hamza1311
    hamza1311 committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    60f44ce View commit details
    Browse the repository at this point in the history

  4. remove uneeded test & todo 

    this test is done at compile time. there's no node_ref field so it can't be set
    @hamza1311
    hamza1311 committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    c1280ac View commit details
    Browse the repository at this point in the history

  5. feature soundness & clippy

    @hamza1311
    hamza1311 committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    8dac14b View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into begone-comp-node-ref

    @hamza1311
    hamza1311 committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    1e26e3a View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. add marker field, in an attempt to reduce bundle size

    @hamza1311
    hamza1311 committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    7b65f3c View commit details
    Browse the repository at this point in the history

  2. Update migration guide

    @hamza1311
    hamza1311 committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    a15b5db View commit details
    Browse the repository at this point in the history