Remove component NodeRef #2783
Merged
Remove component NodeRef #2783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
hamza1311
changed the title
this test is done at compile time. there's no node_ref field so it can't be set
|
Visit the preview URL for this PR (updated for commit a15b5db): https://yew-rs--pr2783-begone-comp-node-ref-vybofh7a.web.app (expires Wed, 27 Jul 2022 16:32:26 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Size Comparison
✅ None of the examples has changed their size significantly. |
futursolo
reviewed
Jul 19, 2022
| #[cfg(feature = "ssr")] | ||
| use crate::platform::io::BufWriter; | ||
|
|
||
| /// A virtual component. | ||
| pub struct VComp { | ||
| pub(crate) type_id: TypeId, | ||
| pub(crate) mountable: Box<dyn Mountable>, | ||
| pub(crate) node_ref: NodeRef, |
There was a problem hiding this comment.
I don't know why is this the case, but the bundle size increase is likely due to the removal of this field.
There was a problem hiding this comment.
Removing a field causing increase in bundle size... That doesn't really make sense to me
Do you know why it might be causing that?
There was a problem hiding this comment.
I think this has something to do with the size of the struct, you can try to replace it with _marker: usize and set the value to 0 in the constructor. This should also work.
There was a problem hiding this comment.
I ran twiggy and it seems like most of bytes are coming from code that is untouched here:
yew/examples/counter_functional [begone-comp-node-ref]〉twiggy diff dist/counter_functional-931e7c89893382d7_bg.wasm dist-pr/counter_functional-ad2bf05e16727653_bg.wasm -n 10
Delta Bytes │ Item
─────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
+510 ┊ yew::dom_bundle::blist::<impl yew::dom_bundle::traits::Reconcilable for yew::virtual_dom::vlist::VList>::reconcile::h897bdbe92f15f88d
-285 ┊ yew::dom_bundle::bcomp::<impl yew::dom_bundle::traits::Reconcilable for yew::virtual_dom::vcomp::VComp>::attach::hbd2d9621b55add0b
+253 ┊ <yew::html::component::lifecycle::CompStateInner<COMP> as yew::html::component::lifecycle::Stateful>::view::h68b91f18b2519e4c
+234 ┊ yew::dom_bundle::bcomp::<impl yew::dom_bundle::traits::Reconcilable for yew::virtual_dom::vcomp::VComp>::attach::hde8285620aedef9a
+150 ┊ yew::dom_bundle::bsuspense::<impl yew::dom_bundle::traits::Reconcilable for yew::virtual_dom::vsuspense::VSuspense>::attach::hb3a4b9fd00446556
+144 ┊ yew::dom_bundle::bnode::<impl yew::dom_bundle::traits::Reconcilable for yew::virtual_dom::vnode::VNode>::reconcile_node::h2888f3017cf1b126
+123 ┊ yew::dom_bundle::blist::BList::apply_unkeyed::hf07a69927390bfbe
+87 ┊ <core::iter::adapters::zip::Zip<A,B> as core::iter::traits::iterator::Iterator>::next::hf228331121bfac52
+60 ┊ yew::dom_bundle::bportal::<impl yew::dom_bundle::traits::Reconcilable for yew::virtual_dom::vportal::VPortal>::attach::h22b2b8a5f486b6e5
+53 ┊ <yew::html::component::lifecycle::RenderRunner as yew::scheduler::Runnable>::run::h84768ff9205d0ffa
+23 ┊ ... and 17 more.
+1352 ┊ Σ [27 Total Rows]
not sure what's happening here
There was a problem hiding this comment.
Yes, it's weird. But increase the size of this struct does work.
376K with-marker/router/dist/router-872e26b381599680_bg.wasm
384K without-marker/router/dist/router-514df72ff86f280e_bg.wasm
futursolo
previously approved these changes
Jul 20, 2022
futursolo
approved these changes
Jul 20, 2022
29 tasks
4 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2505
This is half of #2551/#2567. This PR removes the NodeRef for components. We can add
ComponentRefin the future.cc: @WorldSEnder @futursolo
Checklist