Updated to support keyed attributes #1076

mrh0057 · 2020-04-04T21:31:53Z

Updated to allow keyed attributes.

… a key on the nodes to not process the list. Issue yewstack#479

Switched to using remove instead of get_mut() to make it so we don't need to do a full scan. Issue yewstack#479

Issue yewstack#479.

src/virtual_dom/vtag.rs

src/virtual_dom/vnode.rs

src/virtual_dom/vlist.rs

jstarry · 2020-04-05T12:33:25Z

Thanks for picking this up @mrh0057! This feature is going to help a lot with performance!!

src/virtual_dom/vlist.rs

jstarry · 2020-04-05T12:59:12Z

Another thing to consider is what happens when the root node rendered by a component has a key. It wouldn't do anything.. probably should have a warning I think

Nodes with keys are in a hashmap and nodes without are in vector. Added an error if duplicate keys are in the hashmap and outputs the duplicate key. Issue yewstack#479

Issue yewstack#479

mrh0057 · 2020-04-05T20:21:40Z

Another thing to consider is what happens when the root node rendered by a component has a key. It wouldn't do anything.. probably should have a warning I think

I think by tracking the nodes without a key in a vector fixes this potential issue.

src/virtual_dom/vlist.rs

src/virtual_dom/vnode.rs

src/virtual_dom/vlist.rs

mrh0057 · 2020-04-06T05:59:29Z

I think I've made all the changes requested expect for the vlist to have a key attribute.

jstarry

This is looking great! I added some more comments, but they're mostly small nits. Next step is adding a few macro tests, guide here: https://github.com/yewstack/yew/blob/master/CONTRIBUTING.md#macro-tests

crates/macro/src/html_tree/html_list.rs

crates/macro/src/html_tree/html_tag/mod.rs

src/virtual_dom/vlist.rs

src/virtual_dom/vtag.rs

jstarry · 2020-04-06T08:12:55Z

sweet! thanks so much! last thing is making CI happy, could you please run cargo fmt?

jstarry · 2020-04-06T08:42:26Z

Thanks, there are still two comments that are unaddressed:
#1076 (comment)
#1076 (comment)

Removed the key comparision for vtag.

crates/macro/src/html_tree/html_list.rs

jstarry · 2020-04-13T13:54:29Z

Thanks so much @mrh0057! I just fixed up one last clippy thing and now merging!

Korede-TA · 2020-04-23T15:19:45Z

is this change going to be in the next release of Yew?

jstarry · 2020-04-23T15:21:19Z

@Korede-TA yes! I should be able to put a release soon :)

jstarry · 2020-04-25T11:20:55Z

@Korede-TA v0.15 has just been released with this feature!

deep-gaurav and others added 8 commits March 27, 2020 23:32

Add keys to components

ae23594

Merge branch 'master' of github.com:yewstack/yew

7bd7305

Switched to HashMap for added performance. Fixed issue if their isn't…

66be935

… a key on the nodes to not process the list. Issue yewstack#479

Ran cargo fmt.

b9bd4af

Deleted the node since we don't need it.

ca2f74e

Switched to using remove instead of get_mut() to make it so we don't need to do a full scan. Issue yewstack#479

Changed the key data type to Option<String>.

5ab1aab

Issue yewstack#479.

Removed rls config file.

73fc779

Fixed macro test to add the additional VChild parameter.

c8cafbb

jstarry reviewed Apr 5, 2020

View reviewed changes

src/virtual_dom/vtag.rs Outdated Show resolved Hide resolved

src/virtual_dom/vnode.rs Outdated Show resolved Hide resolved

src/virtual_dom/vlist.rs Outdated Show resolved Hide resolved

jstarry reviewed Apr 5, 2020

View reviewed changes