nested definitions (lots of information in description) #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nested definitions work via a 2-step process. first we select a range of cells we've drawn out representing the nested grammar we want to define, and stage the definition with a particular name. the second portion involves looking for the newly staged grammar definition in the suggestions list, and completing it in order to bind that suggestion to a slot (input grammar) in a parent.
here's a few edge cases to keep in mind:
this PR also doesn't cover cases like:
some bugs this involves:
(see gif below for bugs 2 and 3)