Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep reactive computations synchronous with the render phase #1

Closed
wants to merge 22 commits into from
Closed

keep reactive computations synchronous with the render phase #1

wants to merge 22 commits into from

Commits on Jun 21, 2019

  1. - rewrite useTracker in order to stay fully consistent with current w… 

    …ithTracker behavior

- compare deps in order to keep API consistency to React.useEffect()
    menelike committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    fe4fa42 View commit details
    Browse the repository at this point in the history

  2. - withTracker should always recompute on re-render so deps for useTra… 

    …cker() can be omitted

- also React.memo() already has a check for prop change so there is no need to check for changed deps again
    menelike committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    fbc33c6 View commit details
    Browse the repository at this point in the history

  3. update Readme to reflect omitted deps behavior

    menelike committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    c8d8645 View commit details
    Browse the repository at this point in the history

  4. fix code comment

    menelike committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    44b5247 View commit details
    Browse the repository at this point in the history

  5. get rid of Math.random(), wasn't needed at all

    menelike committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    ddfb7cd View commit details
    Browse the repository at this point in the history

  6. don't handle Meteor.isServer as it's already been taken care of in ex… 

    …ports
    menelike committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    365584f View commit details
    Browse the repository at this point in the history

  7. replace Math.random() when enforcing an update

    menelike committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    c3803b9 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2019

  1. - align areHookInputsEqual with 

    https://github.com/facebook/react/blob/d77d12510b1a1c37484d771a323e0a02cbeb9ba7/packages/react-reconciler/src/ReactFiberHooks.js#L231
https://github.com/facebook/react/blob/d77d12510b1a1c37484d771a323e0a02cbeb9ba7/packages/react-reconciler/src/ReactFiberHooks.js#L318-L329
https://github.com/facebook/react/blob/d77d12510b1a1c37484d771a323e0a02cbeb9ba7/packages/react-reconciler/src/ReactFiberHooks.js#L878

- update comments
    menelike committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    eeb115a View commit details
    Browse the repository at this point in the history

  2. warn if dep is not an array when Meteor isDevelopment

    menelike committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    1eb71dd View commit details
    Browse the repository at this point in the history

  3. fix prevDeps isArray check

    menelike committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    6b540e6 View commit details
    Browse the repository at this point in the history

  4. warn if initial deps is not an array

    menelike committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    8d64e41 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2019

  1. Retain synchronous render behavior for firstRun (including after deps… 

    … change), but allow async and computation reuse after.
    @CaptainN
    CaptainN committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    b1996a2 View commit details
    Browse the repository at this point in the history

  2. Fix eslint errors

    @CaptainN
    CaptainN committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    af6a4a0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'hooks' into half-duplex 

    # Conflicts:
#	packages/react-meteor-data/useTracker.js
    @CaptainN
    CaptainN committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    f31b95d View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2019

  1. disambiguate the disposition of previous computation - this works the… 

    … same as before, but is easier to read
    @CaptainN
    CaptainN committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    be11569 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2019

  1. Merge pull request #1 from CaptainN/half-duplex 

    Half duplex
    @menelike
    menelike committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    d77fab5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'half-duplex' into hooks

    @CaptainN
    CaptainN committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    bfbf823 View commit details
    Browse the repository at this point in the history

  3. Use 1 useRef instead of multiple

    @CaptainN
    CaptainN committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    80fef10 View commit details
    Browse the repository at this point in the history

  4. If reactiveFn will run synchrously next render, don't bother running … 

    …it asynchronously
    @CaptainN
    CaptainN committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    8ae0db4 View commit details
    Browse the repository at this point in the history

  5. Dispose of the computation early, if the deps are falsy on meteor rea… 

    …ctive changes
    @CaptainN
    CaptainN committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    f68ae5b View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2019

  1. previousDeps will always equal deps at this point, so just check prev… 

    …iousDeps
    @CaptainN
    CaptainN committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    c587026 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #3 from CaptainN/hooks 

    Hooks
    @menelike
    menelike committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    d801348 View commit details
    Browse the repository at this point in the history