keep reactive computations synchronous with the render phase #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 21, 2019 18:24
…ithTracker behavior - compare deps in order to keep API consistency to React.useEffect()
…cker() can be omitted - also React.memo() already has a check for prop change so there is no need to check for changed deps again
menelike
changed the title
CaptainN
reviewed
Jun 21, 2019
https://github.com/facebook/react/blob/d77d12510b1a1c37484d771a323e0a02cbeb9ba7/packages/react-reconciler/src/ReactFiberHooks.js#L231 https://github.com/facebook/react/blob/d77d12510b1a1c37484d771a323e0a02cbeb9ba7/packages/react-reconciler/src/ReactFiberHooks.js#L318-L329 https://github.com/facebook/react/blob/d77d12510b1a1c37484d771a323e0a02cbeb9ba7/packages/react-reconciler/src/ReactFiberHooks.js#L878 - update comments
… change), but allow async and computation reuse after.
# Conflicts: # packages/react-meteor-data/useTracker.js
… same as before, but is easier to read
Half duplex
…it asynchronously
|
This is good to go @yched. It retains backward compatibility with |
|
Any thoughts on this @yched ? |
|
Catching up :-) Since you opened meteor#271 on the main repo, I guess this PR here can be closed now, right ? (let's not fork the discussion more than it currently is ;-) ) |
|
superseded by meteor#271 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes meteor#262