Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Viewport syncScrollArea() to Terminal and include force param #1690

Closed
wants to merge 2 commits into from

Conversation

bdrazen
Copy link

@bdrazen bdrazen commented Sep 14, 2018

To allow explicit invocation of scroll sync.

See: microsoft/vscode#58532

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think xterm.js should be smart enough to not need to expose this, it should just work. There's a root cause somewhere, perhaps related to #1607?

@Tyriar
Copy link
Member

Tyriar commented Sep 14, 2018

I notice in vscode that scroll to bottom/top commands don't do anything to the scrollbar, that seems wrong as all they do is forward calls to xterm.js. This also appears to be the case for scroll by line/page as well.

https://github.com/Microsoft/vscode/blob/7ccd93ed5ea3e21b5cf70db7ba73e3adfdd0d0d9/src/vs/workbench/parts/terminal/electron-browser/terminalInstance.ts#L684-L706

@Tyriar
Copy link
Member

Tyriar commented Sep 17, 2018

Fixed in #1698, thanks for the help 😃

@Tyriar Tyriar closed this Sep 17, 2018
@bdrazen bdrazen deleted the expose-syncscroll branch September 17, 2018 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants