Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #58532: fix terminal scroll position when opened #58656

Closed
wants to merge 1 commit into from

Conversation

bdrazen
Copy link

@bdrazen bdrazen commented Sep 14, 2018

Fixes #58532

@msftclas
Copy link

msftclas commented Sep 14, 2018

CLA assistant check
All CLA requirements met.

@Tyriar
Copy link
Member

Tyriar commented Sep 14, 2018

@dbjelovuk did you gain any insights into the root cause of this while investigating? I suspect a change in xterm.js would be the best fix for this.

@bdrazen
Copy link
Author

bdrazen commented Sep 14, 2018

@Tyriar I've tried approaches like calling the xterm's scrollToBottom() and directly calling syncScrollArea() from the _core object with no success. Definitely seems to be an xterm issue needing further investigation, but figured this could serve as a temporary patch job in the interim.

@bdrazen
Copy link
Author

bdrazen commented Sep 14, 2018

@Tyriar I've made an adjustment to xterm that should allow this to be refactored with a simple this._xterm.syncScrollArea(true) in place of the scroll emit.

Problem stemmed from the viewport's underlying _refresh() not being invoked as the buffer didn't change.

this._xterm._core.viewport._refresh() could work just the same in absence of that xterm update. Just need to add the typings.

@Tyriar
Copy link
Member

Tyriar commented Sep 17, 2018

Fixed in xtermjs/xterm.js#1698

@Tyriar Tyriar closed this Sep 17, 2018
@bdrazen bdrazen deleted the terminal-scrollbar branch September 17, 2018 19:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal scrollbar starts at top
3 participants