Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relative path support for Audio and Video Urls to MediaLinks Extension #723

Merged
merged 3 commits into from
Aug 4, 2023

Conversation

RickStrahl
Copy link
Contributor

@RickStrahl RickStrahl commented Jul 11, 2023

Allow detect and embed relative URLs for image tag usage of audio and video links. Relates to #715.

Updated linking looks like this:

image

Note relative links now work picking up media files out of the current folder as well as online links.

@coveralls
Copy link

coveralls commented Jul 11, 2023

Pull Request Test Coverage Report for Build 5546928794

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 17 of 18 (94.44%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 93.342%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Markdig/Extensions/MediaLinks/MediaLinkExtension.cs 13 14 92.86%
Files with Coverage Reduction New Missed Lines %
src/Markdig/Extensions/MediaLinks/MediaLinkExtension.cs 1 96.4%
Totals Coverage Status
Change from base Build 4772706458: 0.02%
Covered Lines: 25987
Relevant Lines: 27242

💛 - Coveralls

Co-authored-by: Günther Foidl <gue@korporal.at>
@RickStrahl
Copy link
Contributor Author

LOL - sure why not?

@RickStrahl RickStrahl closed this Jul 13, 2023
@RickStrahl RickStrahl reopened this Jul 13, 2023
@xoofx xoofx merged commit 053a18c into xoofx:master Aug 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants