Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Links are not rendering non-http links #1035

Closed
zhouxinghong opened this issue May 12, 2023 · 7 comments
Closed

Media Links are not rendering non-http links #1035

zhouxinghong opened this issue May 12, 2023 · 7 comments

Comments

@zhouxinghong
Copy link

zhouxinghong commented May 12, 2023

This tool is great! But want to make a feature request about video preview playback:

  1. Video preview playback should support video file preview playback in Explorer, but currently only supports image preview in Explorer, not video preview playback.
    image

  2. The video preview playback should support the following video insertion preview forms:

![video name](resource folder_files/video name.mp4)

Because this format is very convenient for inserting video files, it has been adopted by other markdown editors. Hope you can support this form of insert preview in the next version.
image

Windows10
3.0.5

@zhouxinghong zhouxinghong reopened this May 30, 2023
@zhouxinghong zhouxinghong reopened this Jun 10, 2023
@zhouxinghong zhouxinghong reopened this Jun 12, 2023
@zhouxinghong zhouxinghong changed the title This tool is great! But want to make a feature request about video preview playback: This tool is great! But want to make a feature request about video preview playback for 3.0.5: Jun 12, 2023
@zhouxinghong zhouxinghong changed the title This tool is great! But want to make a feature request about video preview playback for 3.0.5: This tool is great! But want to make a feature request about video preview playback for 3.0.5 Jun 12, 2023
@RickStrahl
Copy link
Owner

Looks like this is an issue in the Markdig parser which doesn't render media links for non https:// links. When using relative or non-pathed links the media links are embedded as if they were images.

I've filed an issue on the MarkDig repo and probably will take a look later and see why that's not working in their code.

xoofx/markdig#715

@zhouxinghong
Copy link
Author

Other similar markdown editors support non-https:// links to play local videos, and vscode also supports non-https:// links to play local videos, so it is recommended to improve it to make it compatible with more...

@RickStrahl
Copy link
Owner

The following demonstrates the issue.

image

Like I said - the library that provides the markdown parsing has the issue so this needs to get addressed at that end.

@RickStrahl
Copy link
Owner

RickStrahl commented Jun 13, 2023

At the end of the day this probably doesn't matter because most target sites like GitHub can't display any of this.

@RickStrahl RickStrahl changed the title This tool is great! But want to make a feature request about video preview playback for 3.0.5 Media Links are not rendering non-http links Jun 13, 2023
@RickStrahl RickStrahl self-assigned this Jun 13, 2023
@zhouxinghong
Copy link
Author

I'm a layman and I don't know much about its analytical principles. If it is determined that there is a problem with the upstream library, then you can continue to report the problem upwards! Thank you for your hard work and effort! 👍👏😜

@RickStrahl
Copy link
Owner

I've added a pull request to MarkDig to get this issue hopefully addressed in the upstream library:

xoofx/markdig#723

@RickStrahl
Copy link
Owner

Looks like my fixes have been integrated in the latest version of MarkDig, so local and relative links are now working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants