Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eslint-plugin-unicorn from 46.0.0 to 46.0.1 #723

Closed
wants to merge 1 commit into from
Closed

Bump eslint-plugin-unicorn from 46.0.0 to 46.0.1 #723

wants to merge 1 commit into from

Conversation

larouxn
Copy link

@larouxn larouxn commented Jun 7, 2023

Upgrades eslint-plugin-unicorn from 46.0.0 to 47.0.1.

It appears there's an issue with current xo + eslint at 8.40.0 + outdated eslint-plugin-unicorn.

Apparently upgrading eslint-plugin-unicorn resolves the issue for people.

May resolve #718 once a new version of xo is released.

@sindresorhus
Copy link
Member

Thanks, but this is not needed. Semver handles this for us. Read more here: https://nodesource.com/blog/semver-tilde-and-caret All you need to do is to reinstall XO to get it.

@larouxn
Copy link
Author

larouxn commented Jun 8, 2023

Thanks, but this is not needed. Semver handles this for us. Read more here: https://nodesource.com/blog/semver-tilde-and-caret All you need to do is to reinstall XO to get it.

Hmm, that's true, ^46.0.0 should allow us to use the latest ^46.0.x release. That said, wondering what we should do to unbreak this bump since it's breaking due to transitive 46.0.0 of eslint-plugin-unicorn via xo. 🤔

@larouxn larouxn closed this Jun 12, 2023
@larouxn larouxn deleted the bump_eslint_plugin_unicorn_to_46.0.1 branch June 12, 2023 21:17
@larouxn
Copy link
Author

larouxn commented Jun 12, 2023

Closed this, though I do think an explicit requirement of the non-broken v46.0.1 version, v46.0.0 should not be allowed, would be an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails with eslint 8.40.0: TypeError: Cannot read properties of undefined (reading 'getAllComments')
2 participants