Bump eslint-plugin-unicorn from 46.0.0 to 47.0.0

[larouxn]

Upgrades eslint-plugin-unicorn from 46.0.0 to 47.0.0.

• https://www.npmjs.com/package/eslint-plugin-unicorn/v/47.0.0
• https://github.com/sindresorhus/eslint-plugin-unicorn/releases/tag/v47.0.0

It appears there's an issue with current xo + eslint at 8.40.0 + outdated eslint-plugin-unicorn.

• Fails with eslint 8.40.0: TypeError: Cannot read properties of undefined (reading 'getAllComments') #718

Apparently upgrading eslint-plugin-unicorn resolves the issue for people.

• Bug: Cannot read properties of undefined (reading 'getAllComments') eslint/eslint#17167 (comment)

Note, this change Likely requires dropping support for EOL Node 14.

• Require Node 16 and drop support for Node 14 #721

May resolve #718 once a new version of xo is released.

[larouxn]

Need to address linting errors due to the enablement of prefer-at.

test/options-manager.js:102:33
  ✖  102:33  Prefer .at(…) over [….length - index].                                 unicorn/prefer-at
  ✖  128:33  Prefer .at(…) over [….length - index].                                 unicorn/prefer-at
  ✖  129:36  Prefer .at(…) over [….length - index].                                 unicorn/prefer-at
  ✖  433:36  Prefer .at(…) over [….length - index].                                 unicorn/prefer-at

[larouxn]

Looks like Node 14 needs a bit of a custom solution compared to Node 16, 18, and 20. Tested 20 locally.

https://github.com/xojs/xo/actions/runs/5197621435/jobs/9372694163?pr=720

I'm hesitant to suggest doing anything for Node 14 at this point since it's already end-of-life as of April 30th this year. In fact I think we should drop support for Node 14 and add Node 20 as a CI target.

[larouxn]

Closing in favour of the following.

• Bump eslint-plugin-unicorn from 46.0.0 to 46.0.1 #723

Note I still think we should drop Node 14 support and add Node 20 to the CI matrix.