Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify webpack as an optional peer dependency #678

Closed
wants to merge 2 commits into from

Conversation

flying-sheep
Copy link

@flying-sheep flying-sheep commented Aug 9, 2022

This is basically the same PR as vuejs/vue-loader#1853 + vuejs/vue-loader@089473a

See https://yarnpkg.com/configuration/yarnrc#packageExtensions on why this should be fixed here.

Fixes #449

@sindresorhus
Copy link
Member

This is a Yarn issue and I'm simply not interested in working around all the Yarn bugs. Instead, try to get Yarn to fix it.

#449 (comment)

@flying-sheep
Copy link
Author

flying-sheep commented Aug 9, 2022

I think you misunderstood: Yarn is just stricter about the semantics of peer dependencies.

I think if a package uses another package that has a peer dependency, it’s supposed to specify that dependency itself in some fashion. That’s what yarn points out here.

If you think this is a yarn bug, what’s the mistake yarn makes here in your opinion? Do you disagree with its interpretation of peer dependencies, or … ?

@xojs xojs locked and limited conversation to collaborators Aug 10, 2022
@fregante
Copy link
Member

fregante commented Aug 10, 2022

Not the place to discuss Yarn. There's also already an issue for related discussion, which is closed. If resolved, a solution could be applied. This PR doesn't work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning on XO install: has unmet peer dependency webpack
3 participants