Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(extensions): Add webpack optional peerDependency to xo #4723

Merged
merged 5 commits into from Aug 11, 2022

Conversation

flying-sheep
Copy link
Contributor

@flying-sheep flying-sheep commented Aug 9, 2022

What's the problem this PR addresses?
xo depends on eslint-import-resolver-webpack, but only calls into it conditionally.
So while eslint-import-resolver-webpack has a peer dependency on webpack, xo has an optional one.

Upstream PR: xojs/xo#678

...

How did you fix it?
Added a new package extension for xo

...

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit 30ee6d7 into yarnpkg:master Aug 11, 2022
@flying-sheep flying-sheep deleted the patch-1 branch August 11, 2022 09:27
merceyz pushed a commit that referenced this pull request Aug 19, 2022
* Add xo to @yarnpkg/extensions

* oops

* Add release file

* maybe that works?

* missed one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants