Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: honor user configured rules #672

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: honor user configured rules #672

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ef65d5
fix: honor user configured rules
aladdin-add Jun 21, 2022
0ffba0f
fix: refactor to not use optional chaining & nullish
aladdin-add Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 13 additions & 3 deletions lib/options-manager.js
View file
Open in desktop
Expand Up @@ -327,9 +327,19 @@ const buildXOConfig = options => config => {
}

if (options.nodeVersion) {
config.baseConfig.rules['n/no-unsupported-features/es-builtins'] = ['error', {version: options.nodeVersion}];
config.baseConfig.rules['n/no-unsupported-features/es-syntax'] = ['error', {version: options.nodeVersion, ignores: ['modules']}];
config.baseConfig.rules['n/no-unsupported-features/node-builtins'] = ['error', {version: options.nodeVersion}];
const defaults = {
'n/no-unsupported-features/es-builtins': ['error', {version: options.nodeVersion}],
'n/no-unsupported-features/es-syntax': ['error', {version: options.nodeVersion, ignores: ['modules']}],
'n/no-unsupported-features/node-builtins': ['error', {version: options.nodeVersion}],
};
for (const ruleId of Object.keys(defaults)) {
// Should honor user configure.
// Refs: https://github.com/xojs/xo/issues/670
config.baseConfig.rules[ruleId]
= options.rules && options.rules[ruleId] !== undefined
? options.rules[ruleId]
: defaults[ruleId];
}
}

if (options.space && !options.prettier) {
Expand Down