Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: honor user configured rules #672

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: honor user configured rules #672

wants to merge 2 commits into from

Conversation

aladdin-add
Copy link
Contributor

@aladdin-add aladdin-add commented Jun 21, 2022 •
edited

  • fix failing tests
  • add a test

atm, users cannot disable the rules, as the defaults was always applied.
fixes #670 fixes #613

@aladdin-add
fix: honor user configured rules
5ef65d5 
atm, users cannot disable the rules, as the defaults was always applied.
fixes xojs#670
@aladdin-add
Copy link
Contributor Author

the build is failing as ?. and ?? was not supported in node v12, will try to make a change later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@aladdin-add @AndrewMSHowe