Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update CHANGELOG.md through version 0.3.0 #63
docs: Update CHANGELOG.md through version 0.3.0 #63
Changes from 3 commits
67a6d6a
35767f5
bd22311
d4e06a2
35194a7
eac5a4d
38a6983
e94d2ff
c7a6603
fdc468b
79ec886
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subjective: I am torn at this point whether to refer to this repo as a "fork" or as a new project location.
Assuming we continue to publish into the same
xmldom
package on npm, I would not really favor calling this a "fork".OTOH if we would start publishing this as multiple packages in the
@xmldom
namespace on npm, which I had already reserved as an org (see issue #54), then I think "fork" would be appropriate.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about replacing
this fork
with<https://github.com/xmldom/xmldom>
so it stays correct even if it should ever move somewhere else. (Already applied that.)I think "the announcement of the fork" is still the correct wording for describing what happened back then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Not all existing maintainers are "new". Namely @kethinov came from the original
xmldom
project location. And previous maintainers are welcome to join together with us as well. More details are in issue #9.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it could just say "The current maintainers ...", right?
Or we could simplify to "There are currently no plans to continue publishing ..."
Do you want to add a sentence about "old and new maintainers" to that section? Feel free to just do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
the "did not invest time" part is very direct, and unfortunately accurate (perfectly accurate) as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or to "turn the knife" on me:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well not anybody of the "new maintainers" (which I consider to be the new xmldom org + contributors) took the time to do that, So I would leave the sentence as is.
And in case anybody takes the time, the sentence can be removed.