Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update CHANGELOG.md through version 0.3.0 #63

Merged
merged 11 commits into from Oct 2, 2020

Conversation

karfau
Copy link
Member

@karfau karfau commented Jun 27, 2020

Only referencing #62 for further discussions.

@brodybits brodybits added the bug Something isn't working label Jun 28, 2020
CHANGELOG.md Outdated Show resolved Hide resolved
@brodybits
Copy link
Member

In short, info about regressions and most of the info from issue #62 should be included here.

I think some more info about xmldom vs xmldom-alpha as discussed in issues #7 & #62 should be clarified in CHANGELOG.md as well.

I did add the bug label to this. Thanks again!

@karfau

This comment has been minimized.

@brodybits
Copy link
Member

What do you think?

👍 (sorry to say, since these updates to CHANGELOG.md do look like a step in the right direction)

@karfau karfau marked this pull request as draft July 4, 2020 04:29
@karfau
Copy link
Member Author

karfau commented Jul 4, 2020

Just realized that this is a PR, not an issue. My plan is to continue on this. So I'm just marking it as a draft for now.

Only referencing xmldom#62 for further discussions.
@karfau karfau changed the title docs: Update changelog docs: Document changes from v0.1.27 to 0.3.0 Sep 28, 2020
@karfau karfau added the documentation Improvements or additions to documentation label Sep 28, 2020
@karfau
Copy link
Member Author

karfau commented Sep 28, 2020

From my point of view this is done, as far as already published versions are concerned.

I would suggest to introduce (something like) https://github.com/CookPete/auto-changelog to make it easy to update the CHANGELOG in the future.

This is what it could look like with minimal configuration and manual tweaks:
karfau/xmldom@karfau:patch-1...experiment-auto-changelog

I can take care of it directly after this PR, so it can already be applied when releasing 0.4.0

@karfau karfau marked this pull request as ready for review September 28, 2020 07:03
@brodybits
Copy link
Member

I am reviewing this now, my apologies for the delay.

+1 for automating the change log, with some questions coming up

Copy link
Member

@brodybits brodybits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some nits & minor suggestions. In general:

  • I would favor keeping present-tense verbs
  • I would avoid parens in the version section headers, to keep difference from generated anchors as minimal as possible (I hope we will never have to deal with xmldom vs xmldom-alpha packages again)

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@brodybits
Copy link
Member

I have never seen auto-changelog before but am starting to like it. I had seen "conventional commits" before in conventionalcommits.org, with a different tool for updating the changelog and maybe for updating the package version. But it looks like these tools should be able to work together, at least in theory.

This is what it could look like with minimal configuration and manual tweaks:
karfau/xmldom@karfau:patch-1...experiment-auto-changelog

I would probably favor putting this into a PR, which should be easier to review and comment on.

As I said before, I generally have not listed devDependencies and test updates in the change logs, open for discussion.

karfau and others added 2 commits October 2, 2020 07:19
Co-authored-by: Chris Brody <chris.brody+brodybits@gmail.com>
@karfau
Copy link
Member Author

karfau commented Oct 2, 2020

Thx for the review.

I completely removed the notion of xmldom vs xmldom-alpha packages from the headers and added that information just below the publish date.

I converted everything (including older entries) to present tense.

Also made sure the order is always consistent without any empty lines between them

  • BREAKING
  • POSSIBLY BREAKING
  • others

For versions 0.1.25 and 0.1.26 I only added the information we know, and not "Various bugfixes". They have been released on the same day as 0.1.27, so I don't think a lot happened and I don't care enough about those old versions to try and trace the details.

@karfau
Copy link
Member Author

karfau commented Oct 2, 2020

I would probably favor putting this into a PR, which should be easier to review and comment on.

Yes, I just didn't want to invest to much time into it, since I will need to rebase it etc and some details still have to be discussed. I also think it shouldn't block the release of 0.4.0 but it would be nice to already include.

I think the tool just helps to list everything and then it's up to the person publishing the package to decide what information to keep.

@karfau
Copy link
Member Author

karfau commented Oct 2, 2020

Please feel free to merge when you think it's ready.

@brodybits brodybits changed the title docs: Document changes from v0.1.27 to 0.3.0 docs: Fix changes from v0.1.27 to 0.3.0 Oct 2, 2020
@brodybits brodybits changed the title docs: Fix changes from v0.1.27 to 0.3.0 docs: Fix CHANGELOG.md up to to 0.3.0 Oct 2, 2020
@brodybits brodybits changed the title docs: Fix CHANGELOG.md up to to 0.3.0 docs: Update CHANGELOG.md through version 0.3.0 Oct 2, 2020
Copy link
Member

@brodybits brodybits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty to rename this PR (2x) and left what are mostly nits.

One more nit: It looks like we are missing information before version 0.1.18.

I discovered that there is a version 0.1.17 on npm but not in the git history. This would probably be around 2013 or 2014. They may have published 0.1.17 from a special branch or tag in the original repository.

I would probably favor adding a note that details are unknown for versions before 0.1.18.

@karfau I think you should be able to merge this no problem, since it would not be part of a release tag (as a squash commit, please).

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated

## Maintainer changes

After the last commit to the original repository <https://github.com/jindw/xmldom> on the 9th of May 2017, the first commit to this fork is from the 19th of December 2019. [The fork has been announced in the original repository on the 2nd of March 2020.](https://github.com/jindw/xmldom/issues/259)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subjective: I am torn at this point whether to refer to this repo as a "fork" or as a new project location.

Assuming we continue to publish into the same xmldom package on npm, I would not really favor calling this a "fork".

OTOH if we would start publishing this as multiple packages in the @xmldom namespace on npm, which I had already reserved as an org (see issue #54), then I think "fork" would be appropriate.

Copy link
Member Author

@karfau karfau Oct 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about replacing this fork with<https://github.com/xmldom/xmldom> so it stays correct even if it should ever move somewhere else. (Already applied that.)

I think "the announcement of the fork" is still the correct wording for describing what happened back then.


The new maintainers do not plan to continue publishing the `xmldom-alpha` package.

The new maintainers did not invest time to understand changes that led to the last `xmldom` version [`0.1.27`](#0127) published by the original maintainer, but consider it the basis for their work.
Copy link
Member

@brodybits brodybits Oct 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
The new maintainers did not invest time to understand changes that led to the last `xmldom` version [`0.1.27`](#0127) published by the original maintainer, but consider it the basis for their work.
The new maintainer did not invest time to understand changes that led to the last `xmldom` version [`0.1.27`](#0127) published by the original maintainer, but consider it the basis for their work.

the "did not invest time" part is very direct, and unfortunately accurate (perfectly accurate) as well

Copy link
Member

@brodybits brodybits Oct 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or to "turn the knife" on me:

Suggested change
The new maintainers did not invest time to understand changes that led to the last `xmldom` version [`0.1.27`](#0127) published by the original maintainer, but consider it the basis for their work.
The new maintainer @brodybits did not invest time to understand changes that led to the last `xmldom` version [`0.1.27`](#0127) published by the original maintainer, but consider it the basis for their work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well not anybody of the "new maintainers" (which I consider to be the new xmldom org + contributors) took the time to do that, So I would leave the sentence as is.

And in case anybody takes the time, the sentence can be removed.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@brodybits
Copy link
Member

This is what it could look like with minimal configuration and manual tweaks:
karfau/xmldom@karfau:patch-1...experiment-auto-changelog

I would probably favor putting this into a PR

[...]

I also think it shouldn't block the release of 0.4.0 but it would be nice to already include.

I think the tool just helps to list everything and then it's up to the person publishing the package to decide what information to keep.

That makes sense to me.

Maybe a draft PR, that I could use as a starting point for the release of 0.4.0, would make sense. Or maybe not.

It may be ideal to set this up to make npm releases from GitHub actions, someday in the future.

Co-authored-by: Chris Brody <chris.brody+brodybits@gmail.com>
This was referenced Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants