New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add traversal methods to Element #398
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method _insertBefore
is calling the remove method but has extra code for joining inserting a child into the NodeList, can you please check if something also needs to be added there?
We also need some documentation:
|
Thank you a lot for the contribution so far. |
Review fixes committed!
|
Nice, loving it so far
Yeah, that comment is a bit hard to grasp, sorry.
Looks great for me. |
@KevinYeramian This comment points to my main concern for this PR so far. Do you still have capacity to continue working on it? I can help to relsove the conflicts if that's an issue for you. |
# Conflicts: # lib/dom.js # test/dom/element.test.js
I resolved the commit, which leads to failing tests (due to the breaking changes in version 9. |
What does this PR do?
Element
I used the word
traversal
because it used in the official documentation to refers to these methods (link)