feat: add DOM level 4 child element properties #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the properties childElementCount, firstElementChild, lastElementChild, nextElementSibling and previousElementSibling to Element. The first three are also added to Document and DocumentFragment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #652 +/- ##
==========================================
+ Coverage 94.27% 94.38% +0.10%
==========================================
Files 8 8
Lines 2096 2119 +23
Branches 537 544 +7
==========================================
+ Hits 1976 2000 +24
+ Misses 120 119 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
Since #398 seems to be stale and apparently no longer being worked on by the original author, I figured I'd make another attempt.
This PR adds the following properties to
Elementnodes:childElementCountfirstElementChildlastElementChildnextElementSiblingpreviousElementSiblingThese properties correspond to the attributes defined in the
ParentNodeandNonDocumentTypeChildNodemixins in the DOM Living Standard.The first three of these properties are also added to
DocumentandDocumentFragment.