Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PropTypes.func with PropTypes.elementType #640

Merged
merged 2 commits into from Apr 16, 2019

Conversation

maddieeiddam
Copy link
Contributor

@maddieeiddam maddieeiddam commented Mar 1, 2019

Closes #633

@maddieeiddam
Copy link
Contributor Author

@skllcrn @karaggeorge @sindresorhus Hmm - so I can see that the build is failing because it's seeing elementType as an invalid prop type...did I make an error, do I need to change something else, or is elementType just not supported yet?

@sindresorhus
Copy link
Member

The build failure is because of jsx-eslint/eslint-plugin-react#2188. I've disabled the rule in master. Just rebase from master.

@ljharb
Copy link

ljharb commented Mar 3, 2019

That rule enumerates the actual prop-types library; did perhaps someone forget to update prop-types? I see this repo has a lockfile; that's a common bug when using one.

@sindresorhus
Copy link
Member

Yes, it was the lockfile. I thought it was not as I had already tried to uninstall and then reinstall eslint-plugin-react, but it seemed I had to force regenerate the lockfile to make it work.

@sindresorhus
Copy link
Member

Looks good to me.

@maddieeiddam Can you fix the merge conflict?

Copy link
Member

@karaggeorge karaggeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sindresorhus sindresorhus merged commit 7d1dd19 into wulkano:master Apr 16, 2019
@sindresorhus
Copy link
Member

sindresorhus commented Apr 16, 2019

Thanks, @maddieeiddam 🙌 Great contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the new elementType PropType
4 participants