Skip to content

Commit

Permalink
Replace PropTypes.func with PropTypes.elementType (#640)
Browse files Browse the repository at this point in the history
Closes #633
  • Loading branch information
maddieeiddam authored and sindresorhus committed Apr 16, 2019
1 parent 32f9511 commit 7d1dd19
Show file tree
Hide file tree
Showing 29 changed files with 74 additions and 74 deletions.
14 changes: 7 additions & 7 deletions renderer/components/action-bar/controls/advanced.js
Expand Up @@ -167,12 +167,12 @@ class Left extends React.Component {
}

Left.propTypes = {
toggleAdvanced: PropTypes.func.isRequired,
toggleRatioLock: PropTypes.func.isRequired,
toggleAdvanced: PropTypes.elementType.isRequired,
toggleRatioLock: PropTypes.elementType.isRequired,
ratioLocked: PropTypes.bool,
isResizing: PropTypes.bool,
ratio: PropTypes.array,
setRatio: PropTypes.func.isRequired,
setRatio: PropTypes.elementType.isRequired,
advanced: PropTypes.bool
};

Expand Down Expand Up @@ -306,10 +306,10 @@ Right.propTypes = {
ratio: PropTypes.array,
ratioLocked: PropTypes.bool,
advanced: PropTypes.bool,
setBounds: PropTypes.func.isRequired,
swapDimensions: PropTypes.func.isRequired,
setWidth: PropTypes.func.isRequired,
setHeight: PropTypes.func.isRequired,
setBounds: PropTypes.elementType.isRequired,
swapDimensions: PropTypes.elementType.isRequired,
setWidth: PropTypes.elementType.isRequired,
setHeight: PropTypes.elementType.isRequired,
screenWidth: PropTypes.number,
screenHeight: PropTypes.number
};
Expand Down
8 changes: 4 additions & 4 deletions renderer/components/action-bar/controls/main.js
Expand Up @@ -73,8 +73,8 @@ class Left extends React.Component {
}

Left.propTypes = {
toggleAdvanced: PropTypes.func.isRequired,
selectApp: PropTypes.func.isRequired,
toggleAdvanced: PropTypes.elementType.isRequired,
selectApp: PropTypes.elementType.isRequired,
selectedApp: PropTypes.string,
advanced: PropTypes.bool
};
Expand Down Expand Up @@ -113,8 +113,8 @@ class Right extends React.Component {
}

Right.propTypes = {
enterFullscreen: PropTypes.func.isRequired,
exitFullscreen: PropTypes.func.isRequired,
enterFullscreen: PropTypes.elementType.isRequired,
exitFullscreen: PropTypes.elementType.isRequired,
isFullscreen: PropTypes.bool,
advanced: PropTypes.bool
};
Expand Down
2 changes: 1 addition & 1 deletion renderer/components/action-bar/index.js
Expand Up @@ -97,7 +97,7 @@ class ActionBar extends React.Component {
}

ActionBar.propTypes = {
startMoving: PropTypes.func.isRequired,
startMoving: PropTypes.elementType.isRequired,
x: PropTypes.number,
y: PropTypes.number,
width: PropTypes.number,
Expand Down
2 changes: 1 addition & 1 deletion renderer/components/action-bar/record-button.js
Expand Up @@ -210,7 +210,7 @@ RecordButton.propTypes = {
screenWidth: PropTypes.number,
screenHeight: PropTypes.number,
displayId: PropTypes.number,
willStartRecording: PropTypes.func
willStartRecording: PropTypes.elementType
};

export default connect(
Expand Down
12 changes: 6 additions & 6 deletions renderer/components/config/index.js
Expand Up @@ -158,14 +158,14 @@ class Config extends React.Component {
}

Config.propTypes = {
validators: PropTypes.arrayOf(PropTypes.func),
validators: PropTypes.arrayOf(PropTypes.elementType),
values: PropTypes.object,
onChange: PropTypes.func.isRequired,
onChange: PropTypes.elementType.isRequired,
selectedTab: PropTypes.number,
selectTab: PropTypes.func.isRequired,
closeWindow: PropTypes.func.isRequired,
openConfig: PropTypes.func.isRequired,
viewOnGithub: PropTypes.func.isRequired
selectTab: PropTypes.elementType.isRequired,
closeWindow: PropTypes.elementType.isRequired,
openConfig: PropTypes.elementType.isRequired,
viewOnGithub: PropTypes.elementType.isRequired
};

export default connect(
Expand Down
10 changes: 5 additions & 5 deletions renderer/components/config/tab.js
Expand Up @@ -60,7 +60,7 @@ ConfigInput.propTypes = {
PropTypes.string,
PropTypes.bool
]),
onChange: PropTypes.func.isRequired,
onChange: PropTypes.elementType.isRequired,
hasErrors: PropTypes.bool
};

Expand Down Expand Up @@ -128,11 +128,11 @@ class Tab extends React.Component {
}

Tab.propTypes = {
validator: PropTypes.func,
validator: PropTypes.elementType,
values: PropTypes.object,
onChange: PropTypes.func.isRequired,
openConfig: PropTypes.func.isRequired,
viewOnGithub: PropTypes.func.isRequired
onChange: PropTypes.elementType.isRequired,
openConfig: PropTypes.elementType.isRequired,
viewOnGithub: PropTypes.elementType.isRequired
};

export default Tab;
4 changes: 2 additions & 2 deletions renderer/components/cropper/handles.js
Expand Up @@ -85,7 +85,7 @@ Handle.propTypes = {
bottom: PropTypes.bool,
left: PropTypes.bool,
right: PropTypes.bool,
onClick: PropTypes.func.isRequired,
onClick: PropTypes.elementType.isRequired,
ratioLocked: PropTypes.bool
};

Expand Down Expand Up @@ -160,7 +160,7 @@ Handles.propTypes = {
isActive: PropTypes.bool,
width: PropTypes.number,
height: PropTypes.number,
startResizing: PropTypes.func.isRequired,
startResizing: PropTypes.elementType.isRequired,
showHandles: PropTypes.bool,
ratioLocked: PropTypes.bool,
willStartRecording: PropTypes.bool,
Expand Down
2 changes: 1 addition & 1 deletion renderer/components/cropper/index.js
Expand Up @@ -28,7 +28,7 @@ class Cropper extends React.Component {
}

Cropper.propTypes = {
startMoving: PropTypes.func.isRequired,
startMoving: PropTypes.elementType.isRequired,
width: PropTypes.number,
height: PropTypes.number,
isResizing: PropTypes.bool
Expand Down
6 changes: 3 additions & 3 deletions renderer/components/cropper/overlay.js
Expand Up @@ -134,9 +134,9 @@ class Overlay extends React.Component {
}

Overlay.propTypes = {
onMouseUp: PropTypes.func.isRequired,
setCursor: PropTypes.func.isRequired,
startPicking: PropTypes.func.isRequired,
onMouseUp: PropTypes.elementType.isRequired,
setCursor: PropTypes.elementType.isRequired,
startPicking: PropTypes.elementType.isRequired,
x: PropTypes.number,
y: PropTypes.number,
width: PropTypes.number,
Expand Down
4 changes: 2 additions & 2 deletions renderer/components/editor/controls/left.js
Expand Up @@ -48,8 +48,8 @@ class LeftControls extends React.Component {
}

LeftControls.propTypes = {
play: PropTypes.func,
pause: PropTypes.func,
play: PropTypes.elementType,
pause: PropTypes.elementType,
isPaused: PropTypes.bool,
currentTime: PropTypes.number
};
Expand Down
10 changes: 5 additions & 5 deletions renderer/components/editor/controls/play-bar.js
Expand Up @@ -218,14 +218,14 @@ class PlayBar extends React.Component {
PlayBar.propTypes = {
startTime: PropTypes.number,
endTime: PropTypes.number,
seek: PropTypes.func,
seek: PropTypes.elementType,
currentTime: PropTypes.number,
duration: PropTypes.number,
src: PropTypes.string,
setStartTime: PropTypes.func,
setEndTime: PropTypes.func,
pause: PropTypes.func,
play: PropTypes.func,
setStartTime: PropTypes.elementType,
setEndTime: PropTypes.elementType,
pause: PropTypes.elementType,
play: PropTypes.elementType,
hover: PropTypes.bool
};

Expand Down
4 changes: 2 additions & 2 deletions renderer/components/editor/controls/right.js
Expand Up @@ -52,8 +52,8 @@ class RightControls extends React.Component {
RightControls.propTypes = {
hasAudio: PropTypes.bool,
isMuted: PropTypes.bool,
mute: PropTypes.func,
unmute: PropTypes.func,
mute: PropTypes.elementType,
unmute: PropTypes.elementType,
format: PropTypes.string,
duration: PropTypes.number
};
Expand Down
4 changes: 2 additions & 2 deletions renderer/components/editor/options/left.js
Expand Up @@ -121,9 +121,9 @@ class LeftOptions extends React.Component {
LeftOptions.propTypes = {
width: PropTypes.number,
height: PropTypes.number,
changeDimension: PropTypes.func,
changeDimension: PropTypes.elementType,
fps: PropTypes.number,
setFps: PropTypes.func,
setFps: PropTypes.elementType,
originalFps: PropTypes.number,
original: PropTypes.shape({
width: PropTypes.number,
Expand Down
6 changes: 3 additions & 3 deletions renderer/components/editor/options/right.js
Expand Up @@ -73,9 +73,9 @@ RightOptions.propTypes = {
options: PropTypes.arrayOf(PropTypes.object),
format: PropTypes.string,
plugin: PropTypes.string,
selectFormat: PropTypes.func,
selectPlugin: PropTypes.func,
startExport: PropTypes.func
selectFormat: PropTypes.elementType,
selectPlugin: PropTypes.elementType,
startExport: PropTypes.elementType
};

export default connect(
Expand Down
2 changes: 1 addition & 1 deletion renderer/components/editor/options/select.js
Expand Up @@ -72,7 +72,7 @@ class Select extends React.Component {
}

Select.propTypes = {
onChange: PropTypes.func,
onChange: PropTypes.elementType,
options: PropTypes.arrayOf(PropTypes.object),
selected: PropTypes.any
};
Expand Down
2 changes: 1 addition & 1 deletion renderer/components/editor/options/slider.js
Expand Up @@ -147,7 +147,7 @@ Slider.propTypes = {
value: PropTypes.number,
max: PropTypes.number,
min: PropTypes.number,
onChange: PropTypes.func
onChange: PropTypes.elementType
};

export default Slider;
4 changes: 2 additions & 2 deletions renderer/components/editor/video.js
Expand Up @@ -71,8 +71,8 @@ class Video extends React.Component {

Video.propTypes = {
src: PropTypes.string,
setVideo: PropTypes.func,
getSnapshot: PropTypes.func
setVideo: PropTypes.elementType,
getSnapshot: PropTypes.elementType
};

export default connect(
Expand Down
4 changes: 2 additions & 2 deletions renderer/components/exports/export.js
Expand Up @@ -156,8 +156,8 @@ Export.propTypes = {
text: PropTypes.string,
percentage: PropTypes.number,
image: PropTypes.string,
cancel: PropTypes.func,
openInEditor: PropTypes.func,
cancel: PropTypes.elementType,
openInEditor: PropTypes.elementType,
filePath: PropTypes.string,
createdAt: PropTypes.string
};
4 changes: 2 additions & 2 deletions renderer/components/exports/index.js
Expand Up @@ -37,8 +37,8 @@ class Exports extends React.Component {

Exports.propTypes = {
exports: PropTypes.arrayOf(PropTypes.object),
cancel: PropTypes.func,
openInEditor: PropTypes.func,
cancel: PropTypes.elementType,
openInEditor: PropTypes.elementType,
isMounted: PropTypes.bool
};

Expand Down
4 changes: 2 additions & 2 deletions renderer/components/icon-menu.js
Expand Up @@ -33,8 +33,8 @@ class IconMenu extends React.Component {
}

IconMenu.propTypes = {
onOpen: PropTypes.func,
icon: PropTypes.func.isRequired
onOpen: PropTypes.elementType,
icon: PropTypes.elementType.isRequired
};

export default IconMenu;
2 changes: 1 addition & 1 deletion renderer/components/keyboard-number-input.js
Expand Up @@ -22,7 +22,7 @@ class KeyboardNumberInput extends React.Component {
}

KeyboardNumberInput.propTypes = {
onKeyDown: PropTypes.func,
onKeyDown: PropTypes.elementType,
min: PropTypes.number,
max: PropTypes.number
};
Expand Down
12 changes: 6 additions & 6 deletions renderer/components/preferences/categories/general.js
Expand Up @@ -208,19 +208,19 @@ General.propTypes = {
doNotDisturb: PropTypes.bool,
record60fps: PropTypes.bool,
recordKeyboardShortcut: PropTypes.bool,
toggleSetting: PropTypes.func.isRequired,
toggleSetting: PropTypes.elementType.isRequired,
audioInputDeviceId: PropTypes.string,
setAudioInputDeviceId: PropTypes.func.isRequired,
setAudioInputDeviceId: PropTypes.elementType.isRequired,
audioDevices: PropTypes.array,
recordAudio: PropTypes.bool,
kapturesDir: PropTypes.string,
openOnStartup: PropTypes.bool,
allowAnalytics: PropTypes.bool,
loopExports: PropTypes.bool,
pickKapturesDir: PropTypes.func.isRequired,
setOpenOnStartup: PropTypes.func.isRequired,
updateShortcut: PropTypes.func.isRequired,
toggleShortcuts: PropTypes.func.isRequired,
pickKapturesDir: PropTypes.elementType.isRequired,
setOpenOnStartup: PropTypes.elementType.isRequired,
updateShortcut: PropTypes.elementType.isRequired,
toggleShortcuts: PropTypes.elementType.isRequired,
category: PropTypes.string,
cropperShortcut: PropTypes.shape({
metaKey: PropTypes.bool.isRequired,
Expand Down
8 changes: 4 additions & 4 deletions renderer/components/preferences/categories/plugins/index.js
Expand Up @@ -181,11 +181,11 @@ Plugins.propTypes = {
pluginsFromNpm: PropTypes.array,
pluginBeingInstalled: PropTypes.string,
pluginBeingUninstalled: PropTypes.string,
install: PropTypes.func.isRequired,
uninstall: PropTypes.func.isRequired,
onTransitionEnd: PropTypes.func,
install: PropTypes.elementType.isRequired,
uninstall: PropTypes.elementType.isRequired,
onTransitionEnd: PropTypes.elementType,
tab: PropTypes.string,
selectTab: PropTypes.func.isRequired,
selectTab: PropTypes.elementType.isRequired,
npmError: PropTypes.bool,
fetchFromNpm: PropTypes.func.isRequired,
openPluginsConfig: PropTypes.func.isRequired,
Expand Down
6 changes: 3 additions & 3 deletions renderer/components/preferences/categories/plugins/plugin.js
Expand Up @@ -37,7 +37,7 @@ const PluginTitle = ({title, label, onClick}) => (
PluginTitle.propTypes = {
title: PropTypes.string,
label: PropTypes.string,
onClick: PropTypes.func
onClick: PropTypes.elementType
};

const getLink = ({homepage, links}) => homepage || (links && links.homepage);
Expand Down Expand Up @@ -102,8 +102,8 @@ Plugin.propTypes = {
plugin: PropTypes.object,
checked: PropTypes.bool,
disabled: PropTypes.bool,
onTransitionEnd: PropTypes.func,
onClick: PropTypes.func,
onTransitionEnd: PropTypes.elementType,
onClick: PropTypes.elementType,
loading: PropTypes.bool,
openConfig: PropTypes.func,
tabIndex: PropTypes.number.isRequired
Expand Down
2 changes: 1 addition & 1 deletion renderer/components/preferences/categories/plugins/tab.js
Expand Up @@ -75,7 +75,7 @@ EmptyTab.propTypes = {
title: PropTypes.string,
subtitle: PropTypes.string,
link: PropTypes.string,
onClick: PropTypes.func.isRequired,
onClick: PropTypes.elementType.isRequired,
showIcon: PropTypes.bool,
image: PropTypes.string
};
Expand Down
4 changes: 2 additions & 2 deletions renderer/components/preferences/item/index.js
Expand Up @@ -176,12 +176,12 @@ Item.propTypes = {
]),
vertical: PropTypes.bool,
errors: PropTypes.arrayOf(PropTypes.string),
onSubtitleClick: PropTypes.func,
onSubtitleClick: PropTypes.elementType,
warning: PropTypes.oneOfType([
PropTypes.arrayOf(PropTypes.node),
PropTypes.node
]),
onClick: PropTypes.func,
onClick: PropTypes.elementType,
last: PropTypes.bool,
parentItem: PropTypes.bool
};
Expand Down
2 changes: 1 addition & 1 deletion renderer/components/preferences/item/select.js
Expand Up @@ -125,7 +125,7 @@ Select.propTypes = {
label: PropTypes.string,
value: PropTypes.any
})),
onSelect: PropTypes.func.isRequired,
onSelect: PropTypes.elementType.isRequired,
selected: PropTypes.any,
placeholder: PropTypes.string,
noOptionsMessage: PropTypes.string,
Expand Down
2 changes: 1 addition & 1 deletion renderer/components/preferences/navigation.js
Expand Up @@ -97,7 +97,7 @@ class PreferencesNavigation extends React.Component {

PreferencesNavigation.propTypes = {
category: PropTypes.string,
selectCategory: PropTypes.func.isRequired
selectCategory: PropTypes.elementType.isRequired
};

export default connect(
Expand Down

0 comments on commit 7d1dd19

Please sign in to comment.