Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new elementType PropType #633

Closed
sindresorhus opened this issue Feb 16, 2019 · 2 comments · Fixed by #640
Closed

Use the new elementType PropType #633

sindresorhus opened this issue Feb 16, 2019 · 2 comments · Fixed by #640
Labels
Good First Issue Priority: Low Status: In Progress
Projects
3.0.0
Milestone
3.0.0

Comments

@sindresorhus
Copy link
Member

See facebook/prop-types#211

We should use it instead of PropType.func in most places.
@maddieeiddam
Copy link
Contributor

I'm going to start working on this if that's cool :)

@maddieeiddam
Copy link
Contributor

@sindresorhus can you think of any instances where PropTypes.func should NOT be replaced with elementType?

@skllcrn skllcrn added this to the 3.0.0 milestone Mar 1, 2019
@maddieeiddam maddieeiddam mentioned this issue Mar 8, 2019
Merged
@skllcrn skllcrn added this to In progress in 3.0.0 Mar 8, 2019
@skllcrn skllcrn moved this from In progress to Needs review in 3.0.0 Apr 14, 2019
3.0.0 automation moved this from Needs review to Production ready Apr 16, 2019
sindresorhus pushed a commit that referenced this issue Apr 16, 2019
@maddieeiddam @sindresorhus
Replace PropTypes.func with PropTypes.elementType (#640)
7d1dd19 
Closes #633
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Priority: Low Status: In Progress
Projects
No open projects
3.0.0
  
Production ready
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Replace PropTypes.func with PropTypes.elementType maddieeiddam/kap
3 participants
@sindresorhus @skllcrn @maddieeiddam