Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dirhtml builder without ogp_site_url #84

Merged
merged 5 commits into from Nov 22, 2022
Merged

Allow dirhtml builder without ogp_site_url #84

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
756d9e9
Allow dirhtml builder without `ogp_site_url`
rkdarst Nov 8, 2022
27dae4b
Fix ogp_site_url="" default and RTD detection
rkdarst Nov 8, 2022
9b11504
tests/test_options: Add two tests of running with no configuration
rkdarst Nov 9, 2022
df0ad60
Remove unneeded print statement
rkdarst Nov 9, 2022
a2d7545
Update test_options.py
TheTripleV Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 14 additions & 0 deletions tests/test_options.py
View file
Open in desktop
Expand Up @@ -279,3 +279,17 @@ def test_rtd_invalid(app: Sphinx, monkeypatch):

with pytest.raises(Exception):
app.build()


# Test no breakage with no configuration
@pytest.mark.sphinx("html", testroot="no-configuration")
def test_no_configuration_html(og_meta_tags):
print(og_meta_tags)
rkdarst marked this conversation as resolved.
Show resolved Hide resolved
assert get_tag_content(og_meta_tags, "type") == "website"


# Test no breakage with no configuration
@pytest.mark.sphinx("dirhtml", testroot="no-configuration")
def test_no_configuration_dirhtml(og_meta_tags):
print(og_meta_tags)
rkdarst marked this conversation as resolved.
Show resolved Hide resolved
assert get_tag_content(og_meta_tags, "type") == "website"