Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dirhtml builder without ogp_site_url #84

Merged

Commits on Nov 8, 2022

  1. Allow dirhtml builder without ogp_site_url

    - Yes, the readme says that ogp_site_url is very important.  And
      indeed, reports online say that OGP doesn't work with relative URLs.
      Although at least one place says it does...
    - Yet, I got confused when I could build it with html (it left
      everything relative), but not with dirhtml (obscure extension error
      it took me a while to figure out).  (And it only fails on the page
      named `/index`.
    - Set the default ogp_site_url to "" by default, instead of None, to
      make relative by default (previous behavior) instead of raising an
      exception.
    - Even if this isn't perfect, it helps a bit with "make this extension
      do something useful, even if not perfect, if it's installed but not
      configured".
    - So overall, even though this isn't a perfect change, and could be
      considered technically incorrect, I think it's less confusing and
      makes things more consistent for a possibly better solution later.
    rkdarst committed Nov 8, 2022
    Copy the full SHA
    756d9e9 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    27dae4b View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. Copy the full SHA
    9b11504 View commit details
    Browse the repository at this point in the history
  2. Remove unneeded print statement

    Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
    rkdarst and hugovk committed Nov 9, 2022
    Copy the full SHA
    df0ad60 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. Update test_options.py

    TheTripleV committed Nov 22, 2022
    Copy the full SHA
    a2d7545 View commit details
    Browse the repository at this point in the history