Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup integration tests (AdminOnly and DB related) #6627

Merged
merged 69 commits into from
May 17, 2024

Conversation

Tabrisrp
Copy link
Contributor

@Tabrisrp Tabrisrp commented May 9, 2024

Description

AdminOnly tests:

  • Update assertion method to replace deprecated one
  • Skipped test
  • Warning

DB related-tests:

  • Uninstall tables before running tests
  • Run tests against temporary tables whenever possible
  • Some tests have unrelated tables installed to prevent DB request caused by them, but unrelated to the current test
  • Some tests have ATF disabled to prevent DB request caused by this feature, but unrelated to the current test

@Tabrisrp Tabrisrp self-assigned this May 9, 2024
Copy link

codacy-production bot commented May 9, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for c7a71491 100.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c7a7149) Report Missing Report Missing Report Missing
Head commit (1104034) 37174 14349 38.60%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6627) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@MathieuLamiot MathieuLamiot linked an issue May 13, 2024 that may be closed by this pull request
3 tasks
@Tabrisrp Tabrisrp changed the title Integration adminonly cleanup Cleanup integration tests (AdminOnly and DB related) May 17, 2024
@Tabrisrp Tabrisrp marked this pull request as ready for review May 17, 2024 17:49
@Tabrisrp Tabrisrp added this pull request to the merge queue May 17, 2024
Merged via the queue into develop with commit 34c55e9 May 17, 2024
14 checks passed
@Tabrisrp Tabrisrp deleted the fix/integration-admin-cleanup branch May 17, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant