Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Built-in test maintenance: skipped tests, warnings #6607

Closed
3 tasks done
MathieuLamiot opened this issue May 2, 2024 · 0 comments
Closed
3 tasks done

Built-in test maintenance: skipped tests, warnings #6607

MathieuLamiot opened this issue May 2, 2024 · 0 comments
Assignees
@Tabrisrp
Labels
dev initiative

Comments

@MathieuLamiot
Copy link
Contributor

MathieuLamiot commented May 2, 2024 •
edited by Tabrisrp

Context
Logs from WP Rocket CI are messy when it comes to testing. We have a lot of warnings about:

  • Deprecations
  • Skipped tests (flagged as such, or skipped by data provider)
  • Database errors
    etc.

Expected behavior
We should clean the CI logs and fix the reported issues:

  • Fix deprecations
  • If tests are skipped on purpose, consider making them pass or removing them completely?
  • If tests are skipped but not on purpose, fix them.
  • Fix other errors

This might not be a win in one go, but baby steps with incremental PRs are fine. As long as we reduce noise on the CI 👍

Related pull requests:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tabrisrp Tabrisrp

Labels
dev initiative
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tabrisrp @MathieuLamiot