feat: run `stc` from integrations #2342

tzachbon · 2022-02-20T15:05:51Z

We want to give our users a better experience with the integrations and the stc tool.
Today, the user will probably have to run them in different processes to use them together.
This PR introduces a solution. If the integration finds a stcConfig, it will "merge" the processes programmatically, which will result in better diagnostics experience and consistent build order.

Integrations (The CLI will become a dependency)

Support webpack integration.
Support rollup integration and add 2.70.0 of rollup as peerDependency of the package
Update README files.

Feats

loadStylableConfig returns the path of the config too.
Create hooks API for the diagnostic manager.
reportDiagnostic accepts from to the diagnostic report.
CLI supports "config" flag.
unified method to resolve stcConfig
watchMode flag for stc that does not trigger watch but tells stc to be prepared for watching.

Fixes

Log skipped file in stc watcher.
stc watcher now knows about the first process's generated files.

Refactor

move all e2e-test-kit file-system related helpers to a dedicated file.

Test

fix dedup and sort diagnostics test in CLI.

…type

This reverts commit 83e790f.

…e-intergrations

…sed outside the transformation

packages/webpack-plugin/src/loader.ts

barak007 · 2022-03-14T14:49:34Z

packages/webpack-plugin/src/plugin.ts

+            this.createStcBuilder(compiler);
+        });
+
+        compiler.hooks.beforeRun.tapPromise(StylableWebpackPlugin.name, async () => {


remove async await

The type does not allow it

packages/webpack-plugin/src/plugin.ts

…e-intergrations

…ile" This reverts commit d6d0f8c.

… graph; add the file path to the loader diagnostics

tzachbon added 2 commits February 20, 2022 16:46

feat: run stc inside intergrations

f77f535

refactor: remove unused cache variable

9b54a6f

tzachbon mentioned this pull request Feb 21, 2022

feat(cli): use file services resolver in build stylable #2343

Closed

tzachbon added 3 commits February 21, 2022 11:03

deps: update package json with stylable-cli

8f2a264

refactor(e2e-test-kit): file-system helpers

62d2606

test(webpack-plugin): basic stc config

63c9f24

tzachbon self-assigned this Feb 21, 2022

tzachbon added 9 commits February 21, 2022 16:13

feat(webpack): handle file deletion and creation; rename STCProjects …

b97ed5b

…type

chore: clean-ups

fb81a6b

chore: loadStylableConfig return config extracted value

83e790f

feat(cli): support "config" flag

85513c6

Revert "chore: loadStylableConfig return config extracted value"

e11984a

This reverts commit 83e790f.

feat(cli): wrap config resolution methods with 'resolveConfig'

4a1979d

feat(webpack): support stcConfig from the webpack-config

cde2dee

refactor(webpack): clean-ups and reordering

0a989d7

fix(webpack): type fix for the stcBuilder

719d83b

tzachbon added integration Bundler, test-runner and node tooling CLI, stylable-scripts boilerplate labels Feb 21, 2022

tzachbon added 3 commits February 22, 2022 12:20

test(webpack): fix package name

1521e5e

feat(cli): build stylable watchMode flag and watch hooks

9d31580

feat(cli): rewrite stc-builder with better API

5de4898

tzachbon mentioned this pull request Mar 1, 2022

this.addWatchFile does not listen for new files added to a directory rollup/rollup#3704

Closed

tzachbon added 8 commits March 2, 2022 12:54

fix(rollup): rollup starting skeleton

718102b

Merge remote-tracking branch 'origin/master' into tzach/run-stc-insid…

1316b06

…e-intergrations

fix(rollup): handle watched directories

b0589ac

fix: update stc-builder api

e0bc9ba

fix(rollup): use console error since rollup error always throw when u…

62b25c8

…sed outside the transformation

infra: add cli to rollup tsconfig references

ec6ba1d

fix: update stc watch mode api

9780906

fix(cli): remove watch hook

9a583bd

barak007 reviewed Mar 14, 2022

View reviewed changes

packages/webpack-plugin/src/loader.ts Outdated Show resolved Hide resolved

barak007 reviewed Mar 14, 2022

View reviewed changes

packages/webpack-plugin/src/plugin.ts Outdated Show resolved Hide resolved

barak007 reviewed Mar 14, 2022

View reviewed changes

packages/webpack-plugin/src/plugin.ts Outdated Show resolved Hide resolved

tzachbon added 5 commits March 14, 2022 17:50

refactor(cli): unified stc builder rebuild api

9d2f77c

test: use typed configuration in the test fixtures

4668783

refactor: cleaner stc-builder api

5d0a5f6

fix(cli): typo

d05660a

refactor(cli): build-stylable watch options API

17ccc5e

tzachbon requested a review from barak007 March 16, 2022 14:59

tzachbon added 17 commits March 20, 2022 09:40

chore: cleanups

73ad356

Merge remote-tracking branch 'origin/master' into tzach/run-stc-insid…

3a78ea2

…e-intergrations

Merge remote-tracking branch 'origin/master' into tzach/run-stc-insid…

6484d7a

…e-intergrations

refactor(rollup-plugin): separate rollup test to 2 tests functions

ce16478

test(webpack): use promise write file

587f0ec

test(webpack): separate project runner recompilations

c491591

Merge remote-tracking branch 'origin/master' into tzach/run-stc-insid…

e191481

…e-intergrations

test(e2e-test-kit): webpack project runner debounce on recompile

d6d0f8c

test(webpack): add wait-for for the stc in watch mode

daf1d1f

Revert "test(e2e-test-kit): webpack project runner debounce on recomp…

973efa0

…ile" This reverts commit d6d0f8c.

fix(cli): add the initialized files to the affected files

b870084

feat(webpack-plugin): report files that are not part of webpack entry…

6ce4d42

… graph; add the file path to the loader diagnostics

fix(cli): typos

60d80f2

fix(cli): clone diagnostics messages in stc-builder

be23366

Merge branch 'master' into tzach/run-stc-inside-intergrations

e7e33f0

test(webpack-plugin): increase stc test timeout

0d4192e

test(webpack-plugin): assert output file content in stc watch

8fce154

tzachbon merged commit de007a9 into master Apr 5, 2022

tzachbon deleted the tzach/run-stc-inside-intergrations branch April 5, 2022 08:15

tzachbon mentioned this pull request Apr 7, 2022

feat(create-stylable-app): add stcConfig to the integrations templates #2430

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: run `stc` from integrations #2342

feat: run `stc` from integrations #2342

tzachbon commented Feb 20, 2022 •

edited

barak007 Mar 14, 2022

tzachbon Mar 16, 2022

feat: run stc from integrations #2342

feat: run stc from integrations #2342

Conversation

tzachbon commented Feb 20, 2022 • edited

Integrations (The CLI will become a dependency)

Feats

Fixes

Refactor

Test

barak007 Mar 14, 2022

Choose a reason for hiding this comment

tzachbon Mar 16, 2022

Choose a reason for hiding this comment

feat: run `stc` from integrations #2342

feat: run `stc` from integrations #2342

tzachbon commented Feb 20, 2022 •

edited