feat(cli): use file services resolver in build stylable #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AviVahl
reviewed
Feb 21, 2022
AviVahl
reviewed
Feb 21, 2022
|
|
||
| if (resolvedFile === false) { | ||
| throw new Error( | ||
| `Stylable CLI does not support browser field 'false' values. "${request}" resolved to 'false' from "${context}"` |
There was a problem hiding this comment.
How is stylable core handling it?
There was a problem hiding this comment.
tzachbon
added
performance
|
Closing for now (keeping branch). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has mentioned here, this gives us a boost in terms of performance which we like in our CLI for big projects that are going to use our integrations (e.g., webpack, rollup) with
stc.The downside is that the resolver has missing features, but they are very advanced, and most modern tools still do not support them as well.