Respect options passed to data controller on set #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xjiang-at-wiris
requested review from
carla-at-wiris,
jgonzalez-at-wiris,
jhernandez-at-wiris and
usantos-at-wiris
jgonzalez-at-wiris
requested changes
Apr 29, 2024
jgonzalez-at-wiris
approved these changes
Apr 29, 2024
|
Please, could you add the changes.md to the pr ? |
usantos-at-wiris
approved these changes
Apr 30, 2024
carla-at-wiris
approved these changes
Apr 30, 2024
jhernandez-at-wiris
approved these changes
May 9, 2024
This was referenced May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the functions for 'editor.setData' and 'editor.getData' in CKEditor 5 to accept additional arguments when calling the functions.
Steps to reproduce
#taskid 43896