fix(ck5): respect options passed to data controller on set #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguillen-at-wiris
approved these changes
Mar 4, 2024
|
@jguillen-at-wiris It actually occurred to me that I should switch this to use the event mechanism that CKE5 offers for stuff like this, that keeps it from interfering with other plugins that are also trying to use that mechanism. Just pushed a second commit. |
|
This has been included on our latest release. Check the following Pull Request for more information #958 Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make monkey-patched
data.setanddata.getrespect options (and any other arguments that may be added some day)Closes #885