fix: Improve UI performance of ephemeral messages #11071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yserz
approved these changes
May 10, 2021
Codecov Report
@@ Coverage Diff @@
## dev #11071 +/- ##
==========================================
- Coverage 49.44% 43.74% -5.70%
==========================================
Files 370 515 +145
Lines 13759 24375 +10616
Branches 2549 3901 +1352
==========================================
+ Hits 6803 10663 +3860
- Misses 6180 12879 +6699
- Partials 776 833 +57 |
ffflorian
approved these changes
May 10, 2021
bennycode
reviewed
May 10, 2021
| @@ -17,7 +17,7 @@ | |||
| params="user: user, actionsViewModel: actionsViewModel, onAction: onUserAction, isSelfActivated: isActivatedAccount()" | |||
| ></user-actions> | |||
| <!-- /ko --> | |||
| <!-- ko if: !user() && !userNotFound() --> | |||
| <!-- ko if: isVisible() && !user() && !userNotFound() --> | |||
There was a problem hiding this comment.
Does it just hide the loading-icon SVG? If yes, can we completely remove it via JavaScript? Because it seems to be related to this report: wireapp/wire-desktop#2507 (comment)
There was a problem hiding this comment.
This is now there for exactly this reason. The loading-icon will not be in the DOM when it is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.