Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass proper arguments to method callbacks #462

Merged
merged 1 commit into from
Aug 18, 2018

Conversation

nlevitt
Copy link
Contributor

@nlevitt nlevitt commented Aug 15, 2018

There is a regression in 0.49.0 introduced by #442 cc @bashlakov. If you have callbacks (on_open etc) that are methods on a class, but the class is not a subclass of WebsocketApp, it tries to call them with the wrong arguments, and you get an error like this:

2018-08-15 14:43:49,328 79988 ERROR WebsockThread:9222 websocket.error(_logging.py:61) error from callback <bound method WebsockReceiverThread._on_open of <WebsockReceiverThread(WebsockThread:9222, started daemon 123145314500608)>>: _on_open() missing 1 required positional argument: 'websock'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants