adding ability to call instance method as callback #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I understand correctly, when someone inherits from WebSocketApp, and uses an instance method as a callback there is no reason to pass 'self' again to the callback. but if someone uses an instance method of some other class the callback will fail with error: on_open() missing 1 required positional argument: 'ws' or similar My fix allows passing 'self' only once when callback is an instance method of WebSocketApp, but won't fail when the callback is an instance of another class I saw it was already part of the code once : websocket-client@ae58949
|
This should be merged ASAP, latest websocket-client release is breaking compatibility with older code without this fix. |
rad-pat
approved these changes
Jun 10, 2019
|
This is a duplicate of PR #462. However, this callback branch should have been removed in the process of reverting PR #442. However, the revert was not done cleanly, so commit 3112b7d finally removes this callback branch and brings the callback back to where it was before PR #442. Due to commit 3112b7d, this PR is not longer relevant. If you would like to see or comment on the full history on this topic, please see this comment on commit 3112b7d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I understand correctly, when someone inherits from WebSocketApp, and uses an instance method as a callback there is no reason to pass 'self' again to the callback.
but if someone uses an instance method of some other class the callback will fail with error:
on_open() missing 1 required positional argument: 'ws'
or similar
My fix allows passing 'self' only once when callback is an instance method of WebSocketApp, but won't fail when the callback is an instance of another class
I saw it was already part of the code once :
ae58949