fix: declare default commands as optional peer dependencies #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rishabh3112
approved these changes
Sep 21, 2020
anshumanv
approved these changes
Sep 21, 2020
jamesgeorge007
approved these changes
Sep 21, 2020
evenstensberg
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
N/A
Summary
This PR fixes the first issue of #1815 by declaring default command packages (included in
webpack-cli) as optional peer dependencies of@webpack-cli/package-utilsto enable it to resolve them.Does this PR introduce a breaking change?
No