New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove unnecessary optional peer dependencies #1945
Conversation
No, they are needed |
@evilebottnawi This is every require/import calls in webpack-cli/packages/utils/src/ast-utils.ts Lines 1 to 2 in 258219a
webpack-cli/packages/utils/src/global-packages-path.ts Lines 1 to 3 in 258219a
webpack-cli/packages/utils/src/index.ts Lines 1 to 12 in 258219a
webpack-cli/packages/utils/src/modify-config-helper.ts Lines 1 to 8 in 258219a
webpack-cli/packages/utils/src/npm-packages-exists.ts Lines 1 to 7 in 258219a
webpack-cli/packages/utils/src/path-utils.ts Lines 1 to 3 in 258219a
webpack-cli/packages/utils/src/prop-types.ts Lines 1 to 2 in 258219a
webpack-cli/packages/utils/src/recursive-parser.ts Lines 1 to 4 in 258219a
webpack-cli/packages/utils/src/resolve-packages.ts Lines 1 to 8 in 258219a
webpack-cli/packages/utils/src/run-prettier.ts Lines 1 to 2 in 258219a
webpack-cli/packages/utils/src/scaffold.ts Lines 1 to 13 in 258219a
webpack-cli/packages/utils/src/spawn-child.ts Lines 1 to 5 in 258219a
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, my mistake, yes, no need to have it, I think it is webpack-cli
package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What kind of change does this PR introduce?
Bugfix (this doesn't fix any bugs, but in terms of semver I think it should be a fix)
Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
N/A
Summary
In #1816, default commands packages were added to peer dependencies of
@webpack-cli/package-utils
, as they were required bypackageExists
in order to fix #1815.However, in #1822,
packageExists
was moved directly intowebpack-cli
not@webpack-cli/utils
, so@webpack-cli/utils
doesn't require them.Does this PR introduce a breaking change?
No
Other information
Note #1815 has been fixed by #1822.