feat: ability to send headers when connect to browser using puppeteer #9354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Can we update the docs to reflect that headers are also used when connecting to Puppeteer using the devtools automation protocol?
DudaGod
force-pushed
the
feat.cdp_connect_with_headers
branch
from
efe8883
to
c227141
Compare
Fixed. And can you answer for my question about webdriverio@7? Thank you. |
Feel free to bump to v19, there might be some problems that got fixed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
I have browsers pool in some cloud. I want that only users with access will be able to connect to them. So they must provide token through headers. But wdio does not send headers when connect to browser using puppeteer, because puppeteer didn't support it before. But from puppeteer-core@19.4.0 it became possible (PR in puppeteer - puppeteer/puppeteer#9314).
Moreover I want to support it for webdriverio@7, but branch v7 - https://github.com/webdriverio/webdriverio/tree/v7 use puppeteer-core@13.1.3 - https://github.com/webdriverio/webdriverio/blob/v7/packages/webdriverio/package.json#L79. And I'm not sure that I can bump it to 19. What should I do with it?
Reviewers: @webdriverio/project-committers