Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ability to send headers when connect to browser using puppeteer #9386

Merged
merged 3 commits into from Dec 14, 2022
Merged

feat: ability to send headers when connect to browser using puppeteer #9386

merged 3 commits into from Dec 14, 2022

Conversation

DudaGod
Copy link
Contributor

@DudaGod DudaGod commented Dec 12, 2022

Proposed changes

Support changes from #9354 in wdio@7.

Reviewers: @webdriverio/project-committers

@christian-bromann
Copy link
Member

chore: bump puppeteer-core from 13.1.3 to 19.4.0

This caused some type issues due to file refactoring on the Protractor side. You can resolve them checking into the main branch. Let me know if you have any questions.

@DudaGod DudaGod force-pushed the feat.cdp_connect_with_headers_v7 branch 2 times, most recently from 1475fca to 4609583 Compare December 13, 2022 17:48
christian-bromann
christian-bromann approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann
Copy link
Member

Seems that there are still build issues:

Error: ../../../packages/devtools/node_modules/puppeteer-core/lib/types.d.ts(33,5): error TS18028: Private identifiers are only available when targeting ECMAScript 2015 and higher.

@DudaGod DudaGod force-pushed the feat.cdp_connect_with_headers_v7 branch from 4609583 to 0a08c31 Compare December 13, 2022 21:15
@DudaGod
Copy link
Contributor Author

DudaGod commented Dec 13, 2022

Seems that there are still build issues:

Yeah, I see. I will ping you when all the tests pass successfully.

@DudaGod DudaGod force-pushed the feat.cdp_connect_with_headers_v7 branch 4 times, most recently from 14fbdf6 to 89ebc5e Compare December 14, 2022 14:19
@DudaGod DudaGod force-pushed the feat.cdp_connect_with_headers_v7 branch from 89ebc5e to 638e977 Compare December 14, 2022 15:36
@DudaGod
Copy link
Contributor Author

DudaGod commented Dec 14, 2022

I finally fixed everything. Can you review it now?

christian-bromann
christian-bromann reviewed Dec 14, 2022
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍 one question

e2e/wdio/headless/test.e2e.js
Comment on lines +27 to +31
/**
* fails due to "Unable to identify the main resource"
* https://github.com/webdriverio/webdriverio/issues/8541
*/
it.skip('should allow to do performance tests', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this failing for v7 as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, with the same error. So I found that this test skipped in v8 and skip it as well for v7.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

christian-bromann
christian-bromann approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Dec 14, 2022
@christian-bromann christian-bromann merged commit 11d463e into webdriverio:v7 Dec 14, 2022
@DudaGod
Copy link
Contributor Author

DudaGod commented Dec 15, 2022

@christian-bromann can you publish new wdio@7 version to npm? Thank you.

@kyrylodolynskyi
Copy link
Contributor

@DudaGod This version could not be built with ts

@DudaGod
Copy link
Contributor Author

DudaGod commented Dec 19, 2022

This version could not be built with ts

Are you talking about webdriverio@7.28.0 - https://github.com/webdriverio/webdriverio/releases/tag/v7.28.0 ?
What particular error are you getting?

@udarrr udarrr mentioned this pull request Dec 23, 2022
Closed
3 tasks
@christian-bromann
Copy link
Member

@DudaGod I had to revert this change due to the fact that it breaks for folks using Node.js v12 and v13. Maybe this change can be applied without updating Puppeteer.

christian-bromann added a commit that referenced this pull request Dec 24, 2022
@christian-bromann
Revert "feat: ability to send headers when connect to browser using p…
90ace44 
…uppeteer (#9386)"

This reverts commit 11d463e.
@DudaGod
Copy link
Contributor Author

DudaGod commented Dec 26, 2022

I had to revert this change due to the fact that it breaks for folks using Node.js v12 and v13.

Sorry, I did not notice that the required version of node.js has changed in puppeteer-core.

Maybe this change can be applied without updating Puppeteer.

Only if I send a new PR for puppeteer-core@14, but 5 majors have already been released, so they are unlikely to agree to merge my changes. I will try to move to wdio@8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DudaGod @christian-bromann @kyrylodolynskyi