Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(wdio-types): remove implicit dependency on ts-node #8151

Merged
merged 2 commits into from Mar 23, 2022
Merged

chore(wdio-types): remove implicit dependency on ts-node #8151

merged 2 commits into from Mar 23, 2022

Commits on Mar 23, 2022

  1. chore(wdio-types): remove implicit dependency on ts-node 

    Before this, `@wdio/types` needs `ts-node` installed to be used (which is not present in its `dependencies`, `devDependencies` or otherwise). This is pretty annoying if you don't use `ts-node` otherwise.

I have copied the relevant types from `ts-node` and put them into `src/Compiler.ts`.

I have added `typescript` as a `peerDependency`, because `@wdio/types` now depends on types in the `typescript` package itself. Given that `typescript` is _probably installed anyway_ by consumers, it did not seem appropriate to add it to `dependencies`.  I can understand if we just want to drop this from `peerDependencies` altogether, but it _does_ mean that there's still an implicit dependency, which doesn't really solve the problem.
    @boneskull
    boneskull committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    3772462 View commit details
    Browse the repository at this point in the history

  2. Update packages/wdio-types/src/Options.ts

    @christian-bromann
    christian-bromann committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    b578f46 View commit details
    Browse the repository at this point in the history