chore(wdio-types): remove implicit dependency on ts-node #8151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this,
@wdio/types
needsts-node
installed to be used (which is not present in itsdependencies
,devDependencies
or otherwise). This is pretty annoying if you don't usets-node
otherwise.I have copied the relevant types from
ts-node
and put them intosrc/Compiler.ts
.I have added
typescript
as apeerDependency
, because@wdio/types
now depends on types in thetypescript
package itself. Given thattypescript
is probably installed anyway by consumers, it did not seem appropriate to add it todependencies
. I can understand if we just want to drop this frompeerDependencies
altogether, but it does mean that there's still an implicit dependency, which doesn't really solve the problem.Proposed changes
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers