Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getSize if prop is 0 #8136

Merged
merged 2 commits into from Mar 21, 2022
Merged

Fix getSize if prop is 0 #8136

merged 2 commits into from Mar 21, 2022

Conversation

christian-bromann
Copy link
Member

Proposed changes

If the height of an element would be 0 and someone would call getSize("height") the return value would be an object with width and height properties rather than 0 due to an invalid check.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Mar 21, 2022
@christian-bromann christian-bromann requested a review from a team March 21, 2022 13:40
@christian-bromann christian-bromann merged commit d77a890 into main Mar 21, 2022
@christian-bromann christian-bromann deleted the cb-fix-getSize branch March 21, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant