Fix getSize if prop is 0 (#8136)

* fix getSize if prop is 0 * fix test
webdriverio · Mar 21, 2022 · d77a890 · d77a890
1 parent d9ef72f
commit d77a890
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/packages/webdriverio/src/commands/element/getSize.ts b/packages/webdriverio/src/commands/element/getSize.ts
@@ -47,7 +47,7 @@ async function getSize (
         rect = await this.getElementSize(this.elementId) as RectReturn
     }
 
-    if (prop && rect[prop]) {
+    if (prop && typeof rect[prop] === 'number') {
         return rect[prop] as number
     }
 

diff --git a/packages/webdriverio/tests/commands/element/getSize.test.ts b/packages/webdriverio/tests/commands/element/getSize.test.ts
@@ -54,6 +54,8 @@ describe('getSize test', () => {
         expect(width).toBe(50)
         const height = await elem.getSize('height')
         expect(height).toBe(30)
+        const invalid = await elem.getSize('foobar')
+        expect(invalid).toEqual({ width: 50, height: 30 })
     })
 
     afterEach(() => {