URLSearchParams: add tests for two-argument delete() and has() #39865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 5, 2023
nt1m
approved these changes
May 5, 2023
annevk
added a commit
to whatwg/url
that referenced
this pull request
May 5, 2023
webkit-commit-queue
pushed a commit
to annevk/WebKit
that referenced
this pull request
May 5, 2023
https://bugs.webkit.org/show_bug.cgi?id=256369 rdar://108949109 Reviewed by Chris Dumez. Aligns WebKit with a recent URLSearchParams change. Also syncs WPT url/ and new tests are upstreamed via web-platform-tests/wpt#39865. * LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/resources/urltestdata.json: * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-delete.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-delete.any.js: (test): * LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-delete.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-has.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-has.any.js: (test): * LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-has.any.worker-expected.txt: * Source/WebCore/html/URLSearchParams.cpp: (WebCore::URLSearchParams::has const): (WebCore::URLSearchParams::remove): * Source/WebCore/html/URLSearchParams.h: (WebCore::URLSearchParams::remove): (WebCore::URLSearchParams::has const): * Source/WebCore/html/URLSearchParams.idl: Canonical link: https://commits.webkit.org/263726@main
annevk
added a commit
to whatwg/url
that referenced
this pull request
May 8, 2023
Also add <div algorithm> wrappers. Tests: web-platform-tests/wpt#39865. Fixes #335.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatwg/url#735.