Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add value argument to URLSearchParams's has() and delete() #29725

Closed
CYBAI opened this issue May 8, 2023 · 1 comment · Fixed by #29726
Closed

Add value argument to URLSearchParams's has() and delete() #29725

CYBAI opened this issue May 8, 2023 · 1 comment · Fixed by #29726
Labels
I-spec-update

Comments

@CYBAI
Copy link
Member

CYBAI commented May 8, 2023

Spec: whatwg/url#735.
WPT: web-platform-tests/wpt#39865.
@paricbat
Copy link
Contributor

paricbat commented May 8, 2023

I'd like to try fixing this issue, I'll let you know if I need help :)

paricbat added a commit to paricbat/servo that referenced this issue May 8, 2023
@paricbat
Add value argument to URLSearchParams's has() and delete()
f46a05a 
This commit should fix servo#29725.

Signed-off-by: Veronika Bušů <paricbat@email.cz>
@paricbat paricbat mentioned this issue May 8, 2023
Merged
5 tasks
bors-servo added a commit that referenced this issue May 9, 2023
@bors-servo
Auto merge of #29726 - paricbat:urlsearchparams-has-delete, r=<try>
3356a64 
Add value argument to URLSearchParams's has() and delete()

<!-- Please describe your changes on the following line: -->
My first attempt at contributing Rust code!
Add the value argument to `has()` and `done()` as in [the spec](https://url.spec.whatwg.org/#dom-urlsearchparams-delete).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix  #29725 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue May 11, 2023
@bors-servo
Auto merge of #29726 - paricbat:urlsearchparams-has-delete, r=mrobinson
425b0fe 
Add value argument to URLSearchParams's has() and delete()

<!-- Please describe your changes on the following line: -->
My first attempt at contributing Rust code!
Add the value argument to `has()` and `done()` as in [the spec](https://url.spec.whatwg.org/#dom-urlsearchparams-delete).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix  #29725 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-spec-update
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add value argument to URLSearchParams's has() and delete() paricbat/servo
2 participants
@CYBAI @paricbat