Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible to change the mach dependency #4222

Open
AurelienFT opened this issue Sep 20, 2023 · 4 comments · May be fixed by #4250
Open

Is it possible to change the mach dependency #4222

AurelienFT opened this issue Sep 20, 2023 · 4 comments · May be fixed by #4250
Assignees
@Arshia001
Labels
priority-low Low priority issue ❓ question I've a question!
Milestone
v4.5

Comments

@AurelienFT
Copy link

Summary

When using wasmer version 4.2 we have a warning when running a cargo audit on a dependency that you have which is mach. The warning : https://rustsec.org/advisories/RUSTSEC-2020-0168 . They recommend to use an other crate called mach2 which is more maintained. What do you think about this change ?
@AurelienFT AurelienFT added the ❓ question I've a question! label Sep 20, 2023
@AurelienFT AurelienFT mentioned this issue Sep 20, 2023
Open
@Michael-F-Bryan Michael-F-Bryan added the priority-low Low priority issue label Sep 28, 2023
@Michael-F-Bryan Michael-F-Bryan modified the milestones: v4.x, v4.4 Sep 28, 2023
@Michael-F-Bryan
Copy link
Contributor

I've assigned this to @Arshia001. Hopefully mach2 will be a drop-in replacement and we can resolve this immediately, otherwise if switching requires more extensive modifications we may need to put it off until later.

@AurelienFT
Copy link
Author

AurelienFT commented Oct 11, 2023 •
edited

Hello, Any news on that ?

@Arshia001 Arshia001 linked a pull request Oct 11, 2023 that will close this issue
Draft
@Arshia001
Copy link
Member

@AurelienFT I just pushed a change that should fix this, we'll know if mach2 is compatible with mach if the CI turns green.

@Arshia001
Copy link
Member

Actually, it turns out we have to wait for region-rs to publish a new version with the mach2 crate as a dependency.

@Leo-Besancon Leo-Besancon mentioned this issue Oct 16, 2023
Open
45 tasks
@Arshia001 Arshia001 mentioned this issue Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arshia001 Arshia001

Labels
priority-low Low priority issue ❓ question I've a question!
Projects
None yet
Milestone
v4.5
Development

Successfully merging a pull request may close this issue.

replace mach with mach2 wasmerio/wasmer
3 participants
@Arshia001 @Michael-F-Bryan @AurelienFT