replace mach with mach2 #4250
Draft
replace mach with mach2 #4250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arshia001
force-pushed
the
chore-replace-mach-with-mach2
branch
from
132498f
to
9516b24
Compare
syrusakbary
requested changes
Oct 11, 2023
|
Yes, I realised a few minutes too late that that this is not a wasix app 😄 Gonna have to create a PR in region and hope they accept and publish a new version. |
|
@Arshia001 what's the status here? |
|
@theduke we still need to open a PR in |
|
Solution: reach maintianer over mail, and if non-reachable we can create create region2 create with the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4222.
Note, since
machwas also being used byregion, I had to fork and patchregiontoo. The patch can be removed once the changes are merged upstream and released.