Node security meta-issue

[damip]

Functional tests

The goal of functional tests is to run a network of nodes and interact with them to check if consensus is properly achieved, that the network propagates data correctly etc...

Tasks:

• k8s cluster deployment @aoudiamoncef
• connection of the python test framework with the node cluster @sydhds
• Implement operation and block propagation tests under flood #4480 => TODO: test in securenet
• Bootstrap protocol workflow: https://github.com/massalabs/massa-functional-tests/pull/10
• Tests for bootstrap flood resilience #4456: Hard to have a clean setup, in standby
• try bootstrapping with large ledgers. Done in functional tests
• Tests for API flood resilience #4479 @aoudiamoncef Done for the local tests. More extended tests may not be relevant.
• fuzzing

Unit tests and code review

• General considerations
  • cargo audit reports few issues #4396 (waiting on Is it possible to change the mach dependency wasmerio/wasmer#4222, the rest is done) => not under our control
  • remove risky/heavy unused dependencies #4450 @aoudiamoncef
  • aim for better test coverage Unit tests improvements #4418
  • update to rust 1.72.1 (fixes some CVEs)
• fix all tagged security issues: https://github.com/massalabs/massa/labels/Security%20team%20input @AurelienFT
• Models:TODO ASSIGN
  • for all object deserializations (coming from the API, from network, or from bootstrap)
    • check size limits for objects #4593
    • endure that direct bracket accesses are always safe (eg. buffer[i+3:] will panic if i is too big) #4556
    • write unit tests with objects/arrays of exactly the maximum allowed sizes
• Protocol/network add better tests protocol #4461
  • audit the code to ensure safe operation
  • implement unit tests with various connect/disconnect/flood scenarios
  • calibrate bandwidth limits
• Bootstrap #4430
  • ensure that a bootstrapping client can not make a bootstrap server panic by sending invalid data
  • make sure a client cannot deny service by staying connected too long or flooding => Add new tests bootstrap #4509
  • implement unit tests for those aspects Add new tests bootstrap #4509
  • calibrate bandwidth limits and timeout values: Update bootstrap limits (again :) ) #4518
  • Fix Massa-db change history that leads to bootstrap desync. Fix massa db change history handling #4533
  • Finish the main tasks of Bootstrap #4430
• API @modship
  • ensure that no inputs to the API will make the system panic nor stay locked for a lot of time (input checks, length checks)
  • Other limits checks: Calibrate and adjust APIs arguments limits #4475
  • implement API unit tests with edge cases for each public API endpoint API unit tests #4426
• Consensus
  • Check which parts are not covered by unit test coverage and cover them
• Execution @damip
  • Unit test massa-sc-runtime => Update and add execution tests #4504 Restore metering_override and start_func_abi_call original WATs massa-sc-runtime#314
  • Unit test massa-execution-worker #4503
  • Audit code
  • calibrate gas for transaction/roll_buy/roll_sell operations #4464
  • add unit tests on coin spending edge cases #4501 In progress: coins spending tests #4532
  • Remove events in snapshot: Remove events from speculative state snapshot #4511
• Final State @sydhds
  • Internal Audit + Unit testing of massa-final-state and related modules #4435
• POS Worker:
  • Pos worker standalone test #4529