New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(sdk): add many tests for InternalApi.upload_file #4539
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4539 +/- ##
==========================================
+ Coverage 82.98% 83.00% +0.02%
==========================================
Files 261 261
Lines 33263 33263
==========================================
+ Hits 27603 27610 +7
+ Misses 5660 5653 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
wow... i'm excited about this feature! |
…ogic altogether, since it's busted anyway
…eptions vs statuscodes
Let's try to get these fixes into the next release. I think they are causing real failures in the wild. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! some great finds!
@vanpelt @speezepearson I'm unfreezing this branch so merge it when you are ready (probably better sooner, so we could run regression) |
I'm about to start writing an async equivalent for this function, so I want much more thorough unit tests.