Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sdk): add many tests for InternalApi.upload_file #4539

Merged
merged 16 commits into from Dec 2, 2022

Conversation

speezepearson
Copy link
Contributor

@speezepearson speezepearson commented Nov 27, 2022

I'm about to start writing an async equivalent for this function, so I want much more thorough unit tests.

@speezepearson speezepearson requested a review from a team as a code owner November 27, 2022 00:13
@github-actions github-actions bot added cc-test and removed cc-test labels Nov 27, 2022
@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Merging #4539 (1887372) into main (58efdda) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 1887372 differs from pull request most recent head 08fea76. Consider uploading reports for the commit 08fea76 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4539      +/-   ##
==========================================
+ Coverage   82.98%   83.00%   +0.02%     
==========================================
  Files         261      261              
  Lines       33263    33263              
==========================================
+ Hits        27603    27610       +7     
+ Misses       5660     5653       -7     
Flag Coverage Δ
functest 56.67% <0.00%> (+0.03%) ⬆️
unittest 73.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/internal/internal_api.py 89.29% <ø> (-0.39%) ⬇️
wandb/sdk/internal/progress.py 82.50% <100.00%> (ø)
wandb/filesync/step_prepare.py 93.67% <0.00%> (-1.27%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/integration/tensorboard/monkeypatch.py 91.35% <0.00%> (ø)
wandb/sdk/wandb_run.py 90.89% <0.00%> (+0.29%) ⬆️
wandb/sdk/lib/printer.py 89.24% <0.00%> (+0.63%) ⬆️
wandb/sdk/internal/system/system_info.py 91.55% <0.00%> (+3.24%) ⬆️

@kptkin
Copy link
Contributor

kptkin commented Nov 27, 2022

wow... i'm excited about this feature!

wandb/sdk/internal/progress.py Show resolved Hide resolved
wandb/sdk/internal/internal_api.py Show resolved Hide resolved
wandb/sdk/internal/internal_api.py Show resolved Hide resolved
@vanpelt
Copy link
Contributor

vanpelt commented Dec 2, 2022

Let's try to get these fixes into the next release. I think they are causing real failures in the wild.

Copy link
Contributor

@kptkin kptkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! some great finds!

@kptkin
Copy link
Contributor

kptkin commented Dec 2, 2022

@vanpelt @speezepearson I'm unfreezing this branch so merge it when you are ready (probably better sooner, so we could run regression)

@kptkin kptkin added this to the sdk-2022-12.1 milestone Dec 2, 2022
@speezepearson speezepearson enabled auto-merge (squash) December 2, 2022 07:03
@speezepearson speezepearson merged commit bb45a53 into main Dec 2, 2022
@speezepearson speezepearson deleted the spencerpearson/test-upload branch December 2, 2022 07:08
@raubitsj raubitsj self-assigned this Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants