Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(launch): fix the type of the override args passed through to a LaunchProject from a Job #4416

Merged
merged 9 commits into from Nov 7, 2022
Merged

fix(launch): fix the type of the override args passed through to a LaunchProject from a Job #4416

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
88600dd
wip
KyleGoyette Oct 27, 2022
3c09c8e
Merge branch 'main' into launch/fix-broken-job-args
KyleGoyette Oct 27, 2022
3eb1736
update test
KyleGoyette Oct 27, 2022
e3d5ecd
Merge branch 'launch/fix-broken-job-args' of github.com:wandb/client …
KyleGoyette Oct 27, 2022
08b5fac
update
KyleGoyette Oct 27, 2022
8e1a7da
wip
KyleGoyette Oct 27, 2022
2ee8cdb
Merge branch 'main' into launch/fix-broken-job-args
dmitryduev Nov 3, 2022
2ff1019
Merge branch 'main' into launch/fix-broken-job-args
KyleGoyette Nov 7, 2022
bbe7263
fix test
KyleGoyette Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/functional_tests/t0_main/jobs/job_repo_end_to_end.py
View file
Open in desktop
Expand Up @@ -59,4 +59,5 @@
)
assert "requirements.frozen.txt" in os.listdir(lp.project_dir)
print(command)
assert lp.override_args == ["--log-test"]
print(lp.override_args)
assert lp.override_args["--log-test"] is True
6 changes: 3 additions & 3 deletions wandb/apis/public.py
View file
Open in desktop
Expand Up @@ -5198,7 +5198,7 @@ def _configure_launch_project_repo(self, launch_project):
launch_project.add_entry_point(self._entrypoint)
launch_project.python_version = self._source_info.get("runtime")
if self._args:
launch_project.override_args = self._args
launch_project.override_args = util._user_args_to_dict(self._args)

def _configure_launch_project_artifact(self, launch_project):
artifact_string = self._source_info.get("source", {}).get("artifact")
Expand All @@ -5216,7 +5216,7 @@ def _configure_launch_project_artifact(self, launch_project):
launch_project.add_entry_point(self._entrypoint)
launch_project.python_version = self._source_info.get("runtime")
if self._args:
launch_project.override_args = self._args
launch_project.override_args = util._user_args_to_dict(self._args)

def _configure_launch_project_container(self, launch_project):
launch_project.docker_image = self._source_info.get("source", {}).get("image")
Expand All @@ -5227,7 +5227,7 @@ def _configure_launch_project_container(self, launch_project):
if self._entrypoint:
launch_project.add_entry_point(self._entrypoint)
if self._args:
launch_project.override_args = self._args
launch_project.override_args = util._user_args_to_dict(self._args)

def set_entrypoint(self, entrypoint: List[str]):
self._entrypoint = entrypoint
Expand Down